From: Christian Weiske <cweiske@cweiske.de>
Date: Wed, 10 Nov 2010 21:18:41 +0000 (+0100)
Subject: add unit tests for fix_url() and fix a bug I discovered because of them - protocols... 
X-Git-Tag: 1.5.0~301
X-Git-Url: https://git.wh0rd.org/?a=commitdiff_plain;h=444537736be8625a5f2ba15de6c284d91666c011;p=tt-rss.git

add unit tests for fix_url() and fix a bug I discovered because of them - protocols longer than "http" broke url fixing
---

diff --git a/functions.php b/functions.php
index 715d29de..e73c0d16 100644
--- a/functions.php
+++ b/functions.php
@@ -6622,7 +6622,7 @@
 
 		//prepend slash if the URL has no slash in it
 		// "http://www.example" -> "http://www.example/"
-		if (strpos($url, '/', 7) === false) {
+		if (strpos($url, '/', strpos($url, ':') + 3) === false) {
 			$url .= '/';
 		}
 		return $url;
diff --git a/tests/FunctionsTest.php b/tests/FunctionsTest.php
new file mode 100644
index 00000000..61264ac5
--- /dev/null
+++ b/tests/FunctionsTest.php
@@ -0,0 +1,61 @@
+<?php
+require_once dirname(__FILE__) . '/../functions.php';
+/**
+ * Unit tests for functions.php
+ *
+ * @author Christian Weiske <cweiske@php.net>
+ */
+class FunctionsTest extends PHPUnit_Framework_TestCase
+{
+    /**
+     * Test fix_url with feed:// urls
+     */
+    public function testFixUrlFeed()
+    {
+        $this->assertEquals('http://tt-rss.org/', fix_url('feed://tt-rss.org'));
+        $this->assertEquals('http://tt-rss.org/', fix_url('feed://tt-rss.org/'));
+    }
+
+    /**
+     * Test fix_url with non-http protocols
+     */
+    public function testFixUrlProtocols()
+    {
+        $this->assertEquals('https://tt-rss.org/', fix_url('https://tt-rss.org'));
+        $this->assertEquals('ftp://tt-rss.org/', fix_url('ftp://tt-rss.org/'));
+        $this->assertEquals(
+            'reallylongprotocolisthat://tt-rss.org/', 
+            fix_url('reallylongprotocolisthat://tt-rss.org')
+        );
+    }
+
+    /**
+     * Test fix_url with domain names only
+     */
+    public function testFixUrlDomainOnly()
+    {
+        $this->assertEquals('http://tt-rss.org/', fix_url('tt-rss.org'));
+        $this->assertEquals('http://tt-rss.org/', fix_url('tt-rss.org/'));
+        $this->assertEquals('http://tt-rss.org/', fix_url('http://tt-rss.org'));
+        $this->assertEquals('http://tt-rss.org/', fix_url('http://tt-rss.org/'));
+    }
+
+    /**
+     * Test fix_url with domain + paths
+     */
+    public function testFixUrlWithPaths()
+    {
+        $this->assertEquals('http://tt-rss.org/foo', fix_url('tt-rss.org/foo'));
+
+        $this->assertEquals(
+            'http://tt-rss.org/foo/bar/baz',
+            fix_url('tt-rss.org/foo/bar/baz')
+        );
+        $this->assertEquals(
+            'http://tt-rss.org/foo/bar/baz/',
+            fix_url('tt-rss.org/foo/bar/baz/')
+        );
+    }
+}
+
+?>
\ No newline at end of file