From: Benno Schulenberg <bensberg@justemail.net>
Date: Tue, 12 Jan 2016 20:08:31 +0000 (+0000)
Subject: Removing a senseless iteration: simply add the new record at the tail.
X-Git-Tag: v2.5.2~83
X-Git-Url: https://git.wh0rd.org/?a=commitdiff_plain;h=73ee7d7ee541434091a09bc56d41efc4e7373599;p=nano.git

Removing a senseless iteration: simply add the new record at the tail.


git-svn-id: svn://svn.savannah.gnu.org/nano/trunk/nano@5552 35c25a1d-7b9e-4130-9fde-d3aeb78583b8
---

diff --git a/ChangeLog b/ChangeLog
index 95be8e55..cd169619 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,7 @@
 	* src/files.c (load_poshistory): Remove some code duplication.
 	* src/files.c (save_poshistory, update_poshistory, check_poshistory,
 	load_poshistory): Differentiate variable name from function names.
+	* src/files.c (load_poshistory): Remove a senseless iteration.
 
 GNU nano 2.5.1 - 2016.01.11
 
diff --git a/src/files.c b/src/files.c
index b06d46d4..f494a38e 100644
--- a/src/files.c
+++ b/src/files.c
@@ -3217,7 +3217,7 @@ void load_poshistory(void)
 	    char *line = NULL, *lineptr, *xptr;
 	    size_t buf_len = 0;
 	    ssize_t read;
-	    poshiststruct *posptr, *newrecord;
+	    poshiststruct *record_ptr = NULL, *newrecord;
 
 	    /* Read and parse each line, and store the extracted data. */
 	    while ((read = getline(&line, &buf_len, hist)) >= 0) {
@@ -3240,11 +3240,10 @@ void load_poshistory(void)
 		/* Add the record to the list. */
 		if (position_history == NULL)
 		    position_history = newrecord;
-		else {
-		    for (posptr = position_history; posptr->next != NULL;)
-			posptr = posptr->next;
-		    posptr->next = newrecord;
-		}
+		else
+		    record_ptr->next = newrecord;
+
+		record_ptr = newrecord;
 	    }
 	    fclose(hist);
 	    free(line);