From: Stelian Pop <stelian@popies.net>
Date: Fri, 30 Jun 2000 08:57:24 +0000 (+0000)
Subject: Removed the suid-root bit in the default build.
X-Git-Tag: release_0_4b18~3
X-Git-Url: https://git.wh0rd.org/?a=commitdiff_plain;h=882090d1f96018bce58594e1fff5e06340bbc412;p=dump.git

Removed the suid-root bit in the default build.
---

diff --git a/CHANGES b/CHANGES
index 139b14a..fdabbcc 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,4 +1,4 @@
-$Id: CHANGES,v 1.65 2000/06/25 18:42:39 stelian Exp $
+$Id: CHANGES,v 1.66 2000/06/30 08:57:24 stelian Exp $
 
 Changes between versions 0.4b17 and 0.4b18 (released ??????????????)
 ====================================================================
@@ -19,6 +19,12 @@ Changes between versions 0.4b17 and 0.4b18 (released ??????????????)
 	Andreas Hasenack <andreas@conectiva.com.br> for reporting
 	the bugs to me.
 
+4.	Removed the suid-root bit on dump and restore in the
+	default build (and generated RPMs). It should be safer
+	now. Users who need the suid-root capabilities in order
+	to make network backups should read first the man page
+	of dump and enable the suid bit manually.
+
 Changes between versions 0.4b16 and 0.4b17 (released June 1st, 2000)
 ====================================================================
 
diff --git a/configure b/configure
index 6a6911f..370272e 100755
--- a/configure
+++ b/configure
@@ -1465,7 +1465,7 @@ if test "${with_binmode+set}" = set; then
   echo "$ac_t""BINMODE is $withval" 1>&6
 BINMODE=$withval
 else
-  BINMODE=6555
+  BINMODE=0755
 echo "BINMODE defaults to $BINMODE"
 
 fi
@@ -1501,7 +1501,7 @@ if test "${with_manmode+set}" = set; then
   echo "$ac_t""MANMODE is $withval" 1>&6
 MANMODE=$withval
 else
-  MANMODE=0444
+  MANMODE=0644
 echo "MANMODE defaults to $MANMODE"
 
 fi
diff --git a/configure.in b/configure.in
index a35359c..1bc05a6 100644
--- a/configure.in
+++ b/configure.in
@@ -198,7 +198,7 @@ AC_ARG_WITH([binmode],
 [  --with-binmode=MODE        select mode for binaries],
 AC_MSG_RESULT(BINMODE is $withval)
 BINMODE=$withval,
-BINMODE=6555
+BINMODE=0755
 echo "BINMODE defaults to $BINMODE"
 )dnl
 AC_SUBST(BINMODE)
@@ -234,7 +234,7 @@ AC_ARG_WITH([manmode],
 [  --with-manmode=MODE        select mode for manual pages],
 AC_MSG_RESULT(MANMODE is $withval)
 MANMODE=$withval,
-MANMODE=0444
+MANMODE=0644
 echo "MANMODE defaults to $MANMODE"
 )dnl
 AC_SUBST(MANMODE)
diff --git a/dump.spec b/dump.spec
index 1fad91e..139594b 100644
--- a/dump.spec
+++ b/dump.spec
@@ -52,7 +52,7 @@ This packages contains statically linked versions of dump and restore.
 
 %build
 
-./configure --prefix=/usr --with-binmode=6755 --with-manowner=root --with-mangrp=root --with-manmode=0644 --enable-static
+./configure --prefix=/usr --with-binmode=0755 --with-manowner=root --with-mangrp=root --with-manmode=0644 --enable-static
 
 make OPT="$RPM_OPT_FLAGS -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wno-char-subscripts"
 
@@ -61,7 +61,7 @@ mv restore/restore restore/restore.static
 
 make distclean
 
-./configure --prefix=/usr --with-binmode=6755 --with-manowner=root --with-mangrp=root --with-manmode=0644 --enable-rmt --enable-readline
+./configure --prefix=/usr --with-binmode=0755 --with-manowner=root --with-mangrp=root --with-manmode=0644 --enable-rmt --enable-readline
 
 make OPT="$RPM_OPT_FLAGS -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wno-char-subscripts"
 
@@ -94,9 +94,9 @@ rm -rf $RPM_BUILD_ROOT
 %defattr(-,root,root)
 %doc CHANGES COPYRIGHT KNOWNBUGS MAINTAINERS README REPORTING-BUGS THANKS TODO dump.lsm
 %attr(0664,root,disk)	%config(noreplace) /etc/dumpdates
-%attr(6755,root,tty)	/sbin/dump
+%attr(0755,root,tty)	/sbin/dump
 /sbin/rdump
-%attr(6755,root,tty)	/sbin/restore
+%attr(0755,root,tty)	/sbin/restore
 /sbin/rrestore
 %{_prefix}/man/man8/dump.*
 %{_prefix}/man/man8/rdump.*
@@ -111,9 +111,9 @@ rm -rf $RPM_BUILD_ROOT
 
 %files -n dump-static
 %defattr(-,root,root)
-%attr(6755,root,tty)	/sbin/dump.static
+%attr(0755,root,tty)	/sbin/dump.static
 /sbin/rdump.static
-%attr(6755,root,tty)	/sbin/restore.static
+%attr(0755,root,tty)	/sbin/restore.static
 /sbin/rrestore.static
 
 %changelog