From: Andrew Dolgov <fox@bah.spb.su>
Date: Tue, 29 Nov 2005 13:55:53 +0000 (+0100)
Subject: smart RPC I/O is now optional, add functionality to getLabelCounters()
X-Git-Tag: schema_feature_freeze_for_1.1~32
X-Git-Url: https://git.wh0rd.org/?a=commitdiff_plain;h=bbc92e50138a85e5584c73af29c664ff8c1217bf;p=tt-rss.git

smart RPC I/O is now optional, add functionality to getLabelCounters()
---

diff --git a/backend.php b/backend.php
index f79d7249..0d59e790 100644
--- a/backend.php
+++ b/backend.php
@@ -73,7 +73,7 @@
 		print "<counter id='global-unread' counter='$c_id'/>";
 	}
 
-	function getTagCounters($link, $smart_mode = true) {
+	function getTagCounters($link, $smart_mode = SMART_RPC_COUNTERS) {
 
 		if ($smart_mode) {
 			if (!$_SESSION["tctr_last_value"]) {
@@ -119,7 +119,16 @@
 
 	}
 
-	function getLabelCounters($link) {
+	function getLabelCounters($link, $smart_mode = SMART_RPC_COUNTERS) {
+
+		if ($smart_mode) {
+			if (!$_SESSION["lctr_last_value"]) {
+				$_SESSION["lctr_last_value"] = array();
+			}
+		}
+
+		$old_counters = $_SESSION["lctr_last_value"];
+		$lctrs_modified = false;
 
 		$result = db_query($link, "SELECT count(id) as count FROM ttrss_entries,ttrss_user_entries
 			WHERE marked = true AND ttrss_user_entries.ref_id = ttrss_entries.id AND 
@@ -145,10 +154,17 @@
 
 			$count = db_fetch_result($tmp_result, 0, "count");
 
-			print "<label id=\"$id\" counter=\"$count\"/>";
+			if (!$smart_mode || $old_counters[$id] != $count) {	
+				$old_counters[$id] = $count;
+				$lctrs_modified = true;
+				print "<label id=\"$id\" counter=\"$count\"/>";
+			}
 
 			error_reporting (DEFAULT_ERROR_LEVEL);
-	
+		}
+
+		if ($smart_mode && $lctrs_modified) {
+			$_SESSION["lctr_last_value"] = $old_counters;
 		}
 	}
 
@@ -164,7 +180,7 @@
 			print "<feed id=\"$id\" counter=\"$count\"/>";		
 	}
 
-	function getFeedCounters($link, $smart_mode = true) {
+	function getFeedCounters($link, $smart_mode = SMART_RPC_COUNTERS) {
 
 		if ($smart_mode) {
 			if (!$_SESSION["fctr_last_value"]) {
diff --git a/config.php-dist b/config.php-dist
index 68c35ff4..f24906c6 100644
--- a/config.php-dist
+++ b/config.php-dist
@@ -38,4 +38,9 @@
 	// */30 * * * * /usr/bin/wget -O /dev/null -T 600 "http://www.your-site.xxx/tt-rss/backend.php?op=globalUpdateFeeds&daemon=1"
 	//
 
+	define('SMART_RPC_COUNTERS', true);
+	// If enabled, stores feed counter information on the server side and sends
+	// only diffs to the client. In the nutshell, it saves your bandwidth and
+	// makes UI more responsive, but eats server memory.	
+
 ?>