From 0a8365937187a202c87e98a0d91904094f22a2be Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Sat, 20 Nov 2010 15:38:27 +0300 Subject: [PATCH] infobox_callback2: fail on invalid dialog xml --- functions.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/functions.js b/functions.js index e303c404..4f1f3755 100644 --- a/functions.js +++ b/functions.js @@ -466,20 +466,15 @@ function infobox_callback2(transport) { var content; var dtitle = "Dialog"; - if (transport.responseXML) { - var dlg = transport.responseXML.getElementsByTagName("dlg")[0]; - - var title = transport.responseXML.getElementsByTagName("title")[0]; - if (title) - title = title.firstChild.nodeValue; + var dlg = transport.responseXML.getElementsByTagName("dlg")[0]; - var content = transport.responseXML.getElementsByTagName("content")[0]; - - content = content.firstChild.nodeValue; + var title = transport.responseXML.getElementsByTagName("title")[0]; + if (title) + title = title.firstChild.nodeValue; - } else { - content = transport.responseText; - } + var content = transport.responseXML.getElementsByTagName("content")[0]; + + content = content.firstChild.nodeValue; if (!dialog) { dialog = new dijit.Dialog({ -- 2.39.5