From: Mike Frysinger Date: Sat, 28 Sep 2013 04:36:43 +0000 (-0400) Subject: controls: fix hotkeys when focusing elements X-Git-Tag: v3.2~4 X-Git-Url: https://git.wh0rd.org/?p=chrome-ext%2Fmusic-player-client.git;a=commitdiff_plain;h=ccfc12deb15558bccd7d1c5a586fef5b86d386ea controls: fix hotkeys when focusing elements If you're trying to type into a text field, then we don't want to steal the keypresses to switch tabs. --- diff --git a/main.js b/main.js index 266bb1e..1687598 100644 --- a/main.js +++ b/main.js @@ -61,17 +61,23 @@ window.onload = function() { }; window.onkeypress = function(e) { + if (e.target != document.body) { + /* Only allow the shortcuts when the focus is on the body. + Otherwise you can't type these numbers into text fields. */ + return; + } + switch (e.keyCode) { case 49: // 1 show_page('controls'); break; - case 50: // 1 + case 50: // 2 show_page('metadata'); break; - case 51: // 1 + case 51: // 3 show_page('playlist'); break; - case 52: // 1 + case 52: // 4 show_page('options'); break; }