X-Git-Url: https://git.wh0rd.org/?p=dump.git;a=blobdiff_plain;f=common%2Fdumprmt.c;h=503b933162538f513e1fd2f2d42f3f1cfee3da70;hp=5f53079c6ddb7131702af8d8a39a0b2275cb4fb4;hb=401a4d13e4c30d46074531c6c26efefcaf3bbdaf;hpb=f34aca37d19fe46de9acb22249565dfb6491ab2f

diff --git a/common/dumprmt.c b/common/dumprmt.c
index 5f53079..503b933 100644
--- a/common/dumprmt.c
+++ b/common/dumprmt.c
@@ -2,7 +2,8 @@
  *	Ported to Linux's Second Extended File System as part of the
  *	dump and restore backup suit
  *	Remy Card <card@Linux.EU.Org>, 1994-1997
- *	Stelian Pop <pop@cybercable.fr>, 1999
+ *	Stelian Pop <pop@noos.fr>, 1999-2000
+ *	Stelian Pop <pop@noos.fr> - Alcôve <www.alcove.fr>, 2000
  */
 
 /*-
@@ -40,9 +41,10 @@
 
 #ifndef lint
 static const char rcsid[] =
-	"$Id: dumprmt.c,v 1.8 1999/11/02 09:35:56 tiniou Exp $";
+	"$Id: dumprmt.c,v 1.16 2001/02/22 10:57:39 stelian Exp $";
 #endif /* not lint */
 
+#include <config.h>
 #ifdef __linux__
 #include <sys/types.h>
 #include <linux/types.h>
@@ -169,6 +171,7 @@ rmtgetconn(void)
 	int size;
 	int throughput;
 	int on;
+	char *rmtpeercopy;
 
 	rsh = getenv("RSH");
 
@@ -204,19 +207,29 @@ rmtgetconn(void)
 		rshcmd[4] = rmt;
 		rshcmd[5] = NULL;
 
+		/* Restore the uid and gid. We really don't want
+		 * to execute whatever is put into RSH variable with
+		 * more priviledges than needed... */
+		setuid(getuid());
+		setgid(getgid());
+
 		if ((rshpid = piped_child(rshcmd)) < 0) {
 			msg("cannot open connection\n");
 			return 0;
 		}
 	}
 	else {
+		/* Copy rmtpeer to rmtpeercopy to ignore the
+		   return value from rcmd. I cannot figure if
+		   this is this a bug in rcmd or in my code... */
+		rmtpeercopy = (char *)rmtpeer;
 #ifdef KERBEROS
 		if (dokerberos)
-			tormtape = krcmd((char **)&rmtpeer, sp->s_port, tuser, rmt, &errfd,
+			tormtape = krcmd(&rmtpeercopy, sp->s_port, tuser, rmt, &errfd,
 				       (char *)0);
 		else
 #endif
-			tormtape = rcmd((char **)&rmtpeer, (u_short)sp->s_port, pwd->pw_name,
+			tormtape = rcmd(&rmtpeercopy, (u_short)sp->s_port, pwd->pw_name,
 				      tuser, rmt, &errfd);
 		if (tormtape < 0) {
 			msg("login to %s as %s failed.\n", rmtpeer, tuser);
@@ -305,7 +318,7 @@ rmtwrite(const char *buf, size_t count)
 {
 	char line[30];
 
-	(void)snprintf(line, sizeof (line), "W%d\n", count);
+	(void)snprintf(line, sizeof (line), "W%ld\n", (long)count);
 	write(tormtape, line, strlen(line));
 	write(tormtape, buf, count);
 	return (rmtreply("write"));
@@ -450,6 +463,7 @@ int piped_child(const char **command) {
 			msg ("cannot dup2 pipe: %s\n", strerror(errno));
 			exit(1);
 		}
+		setpgid(0, getpid());
 		execvp (command[0], (char *const *) command);
 		msg("cannot exec %s: %s\n", command[0], strerror(errno));
 		exit(1);