From b0e0d7757fe7cdc08be0269f37a7193e07fb1bb3 Mon Sep 17 00:00:00 2001 From: Stelian Pop Date: Thu, 10 Jun 2010 12:17:35 +0000 Subject: [PATCH] Use only ctime to compare newness (instead of both ctime and mtime) --- CHANGES | 11 +++++++++-- dump/traverse.c | 4 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/CHANGES b/CHANGES index 9caf7d8..bcbb3b5 100644 --- a/CHANGES +++ b/CHANGES @@ -1,4 +1,4 @@ -$Id: CHANGES,v 1.312 2010/06/10 12:01:30 stelian Exp $ +$Id: CHANGES,v 1.313 2010/06/10 12:17:35 stelian Exp $ Changes between versions 0.4b42 and 0.4b43 (released ?????????????) =================================================================== @@ -45,7 +45,14 @@ Changes between versions 0.4b42 and 0.4b43 (released ?????????????) 10. Improve level 1 dump speed by rearanging the "mapdirs" code. Thanks to Andreas Kies for finding the - bottleneck and sending a patch. + bottleneck and sending a patch (Sourceforge bug #2998119). + +11. Use only ctime in order to compare newness instead of both + ctime and mtime. This should both speed up dumping time and + correct some side-effect bugs (like dumping files with an mtime + in the future in every incremental backup). Thanks to + Kieran Clancy for reporting the + bug (Sourceforge bug #2999207). Changes between versions 0.4b41 and 0.4b42 (released June 18, 2009) =================================================================== diff --git a/dump/traverse.c b/dump/traverse.c index 0a394ae..6ed1d28 100644 --- a/dump/traverse.c +++ b/dump/traverse.c @@ -37,7 +37,7 @@ #ifndef lint static const char rcsid[] = - "$Id: traverse.c,v 1.70 2010/06/10 12:01:30 stelian Exp $"; + "$Id: traverse.c,v 1.71 2010/06/10 12:17:35 stelian Exp $"; #endif /* not lint */ #include @@ -240,7 +240,7 @@ blockest(struct dinode const *dp) #define MSINCE(dp, t) \ ((dp)->di_mtime >= (t)) #define CHANGEDSINCE(dp, t) \ - (CSINCE(dp, t) || MSINCE(dp, t)) + CSINCE(dp, t) /* The NODUMP_FLAG macro tests if a file has the nodump flag. */ #ifdef UF_NODUMP -- 2.39.2