[sysvinit.git] / contrib / alexander.viro

I proposed moving some stuff to a seperate file, such as the
re-exec routines. Alexander wrote:


According to Alexander Viro <viro@math.psu.edu>:
> As for the code separation - I think it's nice. Actually, read_inittab()
> with get_part() and newFamily are also pretty separatable. Another good
> set is any(), spawn(), startup(), spawn_emerg() and start_if_needed().
> BTW, fail_check();process_signals(); is equivalent to process_signal();
> fail_check();. I think that swapping them (in main loop) would be a good
> idea - then we can move fail_check() into start_if_needed(). And one more
> - I'ld propose to move start_if_needed to the beginning of the main loop,
> as in
>       foo();
>       while(1) { bar();foo();
> #if 0
>               baz();
> #endif
>       }
> to
>       while(1) { foo();bar();
> #if 0
>               baz();
> #endif
>       }
>
>
> What do you think about it?
Commit	Line	Data
a74aeac6 PR	1	I proposed moving some stuff to a seperate file, such as the
	2	re-exec routines. Alexander wrote:
	3
	4
	5	According to Alexander Viro <viro@math.psu.edu>:
	6	> As for the code separation - I think it's nice. Actually, read_inittab()
	7	> with get_part() and newFamily are also pretty separatable. Another good
	8	> set is any(), spawn(), startup(), spawn_emerg() and start_if_needed().
	9	> BTW, fail_check();process_signals(); is equivalent to process_signal();
	10	> fail_check();. I think that swapping them (in main loop) would be a good
	11	> idea - then we can move fail_check() into start_if_needed(). And one more
	12	> - I'ld propose to move start_if_needed to the beginning of the main loop,
	13	> as in
	14	> foo();
	15	> while(1) { bar();foo();
	16	> #if 0
	17	> baz();
	18	> #endif
	19	> }
	20	> to
	21	> while(1) { foo();bar();
	22	> #if 0
	23	> baz();
	24	> #endif
	25	> }
	26	>
	27	>
	28	> What do you think about it?
	29