From: Andrew Dolgov <noreply@fakecake.org>
Date: Mon, 15 Oct 2018 05:26:07 +0000 (+0300)
Subject: validate_session: bring back IP session binding (enabled by default) and UA checking
X-Git-Tag: 18.12~61
X-Git-Url: https://git.wh0rd.org/?p=tt-rss.git;a=commitdiff_plain;h=7d53c2b501cbc0e48f90c154b2f901fef08fbd33

validate_session: bring back IP session binding (enabled by default) and UA checking
---

diff --git a/include/sessions.php b/include/sessions.php
index c80c21de..f625cd16 100644
--- a/include/sessions.php
+++ b/include/sessions.php
@@ -49,6 +49,19 @@
         $pdo = Db::pdo();
 
 		if ($_SESSION["uid"]) {
+
+			if (!defined('_SKIP_SESSION_ADDRESS_CHECKS') || !_SKIP_SESSION_ADDRESS_CHECKS) {
+				if ($_SESSION["ip_address"] != $_SERVER["REMOTE_ADDR"]) {
+					$_SESSION["login_error_msg"] = __("Session failed to validate.");
+					return false;
+				}
+			}
+
+			if ($_SESSION["user_agent"] != sha1($_SERVER['HTTP_USER_AGENT'])) {
+				$_SESSION["login_error_msg"] = __("Session failed to validate.");
+				return false;
+			}
+
 			$sth = $pdo->prepare("SELECT pwd_hash FROM ttrss_users WHERE id = ?");
 			$sth->execute([$_SESSION['uid']]);