Use of ":=" in src/Makefile.am is unportable (bug 14420)

Building 2.5.91 on Solaris with the native make(1) yields

...
Making all in src
make: Fatal error in reader: Makefile, line 313: Unexpected end of line seen
Current working directory /tmp/fontconfig-2.5.91/src
*** Error code 1

This is due to the following line (src/Makefile.am:143):

    CLEANFILES := $(ALIAS_FILES)

Changing that to a standard assignment ("=") fixes the problem.

I believe the ":=" is a typo. ALIAS_FILES is just a statically assigned
variable; it's not like evaluating it more than once would be a problem.

diff --git a/src/Makefile.am b/src/Makefile.am
index c2282af31a66bf1add8ffb4b0011152e9370aa31..129d74bf7df348158963698b24ed23c948d495ab 100644 (file)
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -140,7 +140,7 @@ fcftaliastail.h: fcftalias.h
 fcftalias.h: $(top_srcdir)/src/makealias $(PUBLIC_FT_FILES)
        sh $(top_srcdir)/src/makealias "$(top_srcdir)/src" fcftalias.h fcftaliastail.h $(PUBLIC_FT_FILES)
 
-CLEANFILES := $(ALIAS_FILES)
+CLEANFILES = $(ALIAS_FILES)
 
 fontconfig.def: $(PUBLIC_FILES)
        echo Generating $@