remove some unused code reported by phpmd

[tt-rss.git] / classes / feeds.php

diff --git a/classes/feeds.php b/classes/feeds.php
index 86a426208c74d4c8c031b483289ab18aba59b571..ea3967911f1a96bbccd807f5d38d0ed4e1dc71bc 100644 (file)
--- a/classes/feeds.php
+++ b/classes/feeds.php
@@ -13,12 +13,6 @@ class Feeds extends Handler_Protected {
                        $feed_id, $is_cat, $search,
                        $search_mode, $view_mode, $error, $feed_last_updated) {
 
-               $page_prev_link = "viewFeedGoPage(-1)";
-               $page_next_link = "viewFeedGoPage(1)";
-               $page_first_link = "viewFeedGoPage(0)";
-
-               $catchup_page_link = "catchupPage()";
-               $catchup_feed_link = "catchupCurrentFeed()";
                $catchup_sel_link = "catchupSelection()";
 
                $archive_sel_link = "archiveSelection()";
@@ -62,15 +56,13 @@ class Feeds extends Handler_Protected {
 #              $reply .= "<span>";
                $reply .= "<span id='feed_title' class='$error_class'>";
 
-               $reply .= "</span>";
-
                if ($feed_site_url) {
                        $last_updated = T_sprintf("Last updated: %s",
                                $feed_last_updated);
 
                        $target = "target=\"_blank\"";
                        $reply .= "<a title=\"$last_updated\" $target href=\"$feed_site_url\">".
-                               truncate_string($feed_title,30)."</a>";
+                               truncate_string($feed_title, 30)."</a>";
 
                        if ($error) {
                                $error = htmlspecialchars($error);
@@ -83,6 +75,8 @@ class Feeds extends Handler_Protected {
 
                $reply .= "</span>";
 
+               $reply .= "</span>";
+
 #              $reply .= "</span>";
 
                // left part
@@ -292,8 +286,6 @@ class Feeds extends Handler_Protected {
                        $num_unread = 0;
                        $cur_feed_title = '';
 
-                       $fresh_intl = get_pref("FRESH_ARTICLE_MAX_AGE") * 60 * 60;
-
                        if ($_REQUEST["debug"]) $timing_info = print_checkpoint("PS", $timing_info);
 
                        $expand_cdm = get_pref('CDM_EXPANDED');
@@ -480,17 +472,18 @@ class Feeds extends Handler_Protected {
 
                                        $reply['content'] .= "</div>";
 
-                                       $reply['content'] .= "<span class=\"hlUpdated\">";
-
                                        if (!get_pref('VFEED_GROUP_BY_FEED')) {
                                                if (@$line["feed_title"]) {
                                                        $rgba = @$rgba_cache[$feed_id];
 
-                                                       $reply['content'] .= "<a class=\"hlFeed\" style=\"background : rgba($rgba, 0.3)\" href=\"#\" onclick=\"viewfeed($feed_id)\">".
-                                                               truncate_string($line["feed_title"],30)."</a>";
+                                                       $reply['content'] .= "<span class=\"hlFeed\"><a style=\"background : rgba($rgba, 0.3)\" href=\"#\" onclick=\"viewfeed($feed_id)\">".
+                                                               truncate_string($line["feed_title"],30)."</a></span>";
                                                }
                                        }
 
+
+                                       $reply['content'] .= "<span class=\"hlUpdated\">";
+
                                        $reply['content'] .= "<div title='$date_entered_fmt'>$updated_fmt</div>
                                                </span>";
 
@@ -556,7 +549,7 @@ class Feeds extends Handler_Protected {
                                        $reply['content'] .= "<div class=\"cdm $hlc_suffix $expanded_class $class\"
                                                id=\"RROW-$id\" orig-feed-id='$feed_id' $mouseover_attrs>";
 
-                                       $reply['content'] .= "<div class=\"cdmHeader\" style=\"$row_background\">";
+                                       $reply['content'] .= "<div class=\"cdmHeader\">";
                                        $reply['content'] .= "<div style=\"vertical-align : middle\">";
 
                                        $reply['content'] .= "<input dojoType=\"dijit.form.CheckBox\"
@@ -810,8 +803,6 @@ class Feeds extends Handler_Protected {
 
                if ($_REQUEST["debug"]) $timing_info = print_checkpoint("0", $timing_info);
 
-               $omode = $this->dbh->escape_string($_REQUEST["omode"]);
-
                $feed = $this->dbh->escape_string($_REQUEST["feed"]);
                $method = $this->dbh->escape_string($_REQUEST["m"]);
                $view_mode = $this->dbh->escape_string($_REQUEST["view_mode"]);
@@ -904,7 +895,7 @@ class Feeds extends Handler_Protected {
 
                //$topmost_article_ids = $ret[0];
                $headlines_count = $ret[1];
-               $returned_feed = $ret[2];
+               /* $returned_feed = $ret[2]; */
                $disable_cache = $ret[3];
                $vgroup_last_feed = $ret[4];
 
@@ -1084,20 +1075,18 @@ class Feeds extends Handler_Protected {
                print " <select dojoType=\"dijit.form.Select\" name=\"limit\" onchange=\"dijit.byId('feedBrowserDlg').update()\">";
 
                foreach (array(25, 50, 100, 200) as $l) {
-                       $issel = ($l == $limit) ? "selected=\"1\"" : "";
-                       print "<option $issel value=\"$l\">$l</option>";
+                       //$issel = ($l == $limit) ? "selected=\"1\"" : "";
+                       print "<option value=\"$l\">$l</option>";
                }
 
                print "</select> ";
 
                print "</div>";
 
-               $owner_uid = $_SESSION["uid"];
-
                require_once "feedbrowser.php";
 
                print "<ul class='browseFeedList' id='browseFeedList'>";
-               print make_feed_browser($search, 25);
+               print make_feed_browser("", 25);
                print "</ul>";
 
                print "<div align='center'>