Fixing bugs found by static analysis

[tt-rss.git] / classes / pluginhost.php

diff --git a/classes/pluginhost.php b/classes/pluginhost.php
index 9ebabeb8c343c8f2abc28f88fc6ab8517b80912c..bc5dc96beb5c0ca4cc47e40aa9bbe46d0b1317fe 100644 (file)
--- a/classes/pluginhost.php
+++ b/classes/pluginhost.php
@@ -34,6 +34,8 @@ class PluginHost {
        const HOOK_HEADLINE_TOOLBAR_BUTTON = 17;
        const HOOK_HOTKEY_INFO = 18;
        const HOOK_ARTICLE_LEFT_BUTTON = 19;
+       const HOOK_PREFS_EDIT_FEED = 20;
+       const HOOK_PREFS_SAVE_FEED = 21;
 
        const KIND_ALL = 1;
        const KIND_SYSTEM = 2;
@@ -41,9 +43,8 @@ class PluginHost {
 
        function __construct() {
                $this->dbh = Db::get();
-               $this->storage = $_SESSION["plugin_storage"];
 
-               if (!$this->storage) $this->storage = array();
+               $this->storage = array();
        }
 
        private function __clone() {
@@ -185,7 +186,7 @@ class PluginHost {
                }
        }
 
-       function del_handler($handler, $method) {
+       function del_handler($handler, $method, $sender) {
                $handler = str_replace("-", "_", strtolower($handler));
                $method = strtolower($method);
 
@@ -250,17 +251,13 @@ class PluginHost {
        }
 
        function load_data($force = false) {
-               if ($this->owner_uid && (!$_SESSION["plugin_storage"] || $force))  {
-                       $plugin = $this->dbh->escape_string($plugin);
-
+               if ($this->owner_uid)  {
                        $result = $this->dbh->query("SELECT name, content FROM ttrss_plugin_storage
                                WHERE owner_uid = '".$this->owner_uid."'");
 
                        while ($line = $this->dbh->fetch_assoc($result)) {
                                $this->storage[$line["name"]] = unserialize($line["content"]);
                        }
-
-                       $_SESSION["plugin_storage"] = $this->storage;
                }
        }
 
@@ -300,8 +297,6 @@ class PluginHost {
 
                $this->storage[$idx][$name] = $value;
 
-               $_SESSION["plugin_storage"] = $this->storage;
-
                if ($sync) $this->save_data(get_class($sender));
        }
 
@@ -329,8 +324,6 @@ class PluginHost {
 
                        $this->dbh->query("DELETE FROM ttrss_plugin_storage WHERE name = '$idx'
                                AND owner_uid = " . $this->owner_uid);
-
-                       $_SESSION["plugin_storage"] = $this->storage;
                }
        }