]> git.wh0rd.org - tt-rss.git/blobdiff - classes/pref/filters.php
implement filter drag and drop sorting
[tt-rss.git] / classes / pref / filters.php
index 2eed4dee92bd5bd9f642ce7b8c998ccf1446f1e4..6ccff51d76fe3d765e3e913cc32a34eb80b72746 100644 (file)
@@ -3,17 +3,56 @@ class Pref_Filters extends Handler_Protected {
 
        function csrf_ignore($method) {
                $csrf_ignored = array("index", "getfiltertree", "edit", "newfilter", "newrule",
-                       "newaction");
+                       "newaction", "savefilterorder");
 
                return array_search($method, $csrf_ignored) !== false;
        }
 
+       function filtersortreset() {
+               db_query($this->link, "UPDATE ttrss_filters2
+                               SET order_id = 0 WHERE owner_uid = " . $_SESSION["uid"]);
+               return;
+       }
+
+       function savefilterorder() {
+               $data = json_decode($_POST['payload'], true);
+
+               #file_put_contents("/tmp/saveorder.json", $_POST['payload']);
+               #$data = json_decode(file_get_contents("/tmp/saveorder.json"), true);
+
+               if (!is_array($data['items']))
+                       $data['items'] = json_decode($data['items'], true);
+
+               $index = 0;
+
+               if (is_array($data) && is_array($data['items'])) {
+                       foreach ($data['items'][0]['items'] as $item) {
+                               $filter_id = (int) str_replace("FILTER:", "", $item['_reference']);
+
+                               if ($filter_id > 0) {
+
+                                       db_query($this->link, "UPDATE ttrss_filters2 SET
+                                               order_id = $index WHERE id = '$filter_id' AND
+                                               owner_uid = " .$_SESSION["uid"]);
+
+                                       ++$index;
+                               }
+                       }
+               }
+
+               return;
+       }
+
+
        function testFilter() {
                $filter = array();
 
                $filter["enabled"] = true;
                $filter["match_any_rule"] = sql_bool_to_bool(
-                       checkbox_to_sql_bool(db_escape_string($_REQUEST["match_any_rule"])));
+                       checkbox_to_sql_bool(db_escape_string($this->link, $_REQUEST["match_any_rule"])));
+               $filter["inverse"] = sql_bool_to_bool(
+                       checkbox_to_sql_bool(db_escape_string($this->link, $_REQUEST["inverse"])));
+
                $filter["rules"] = array();
 
                $result = db_query($this->link, "SELECT id,name FROM ttrss_filter_types");
@@ -47,7 +86,7 @@ class Pref_Filters extends Handler_Protected {
                $feed_title = getFeedTitle($this->link, $feed);
 
                $qfh_ret = queryFeedHeadlines($this->link, -4, 30, "", false, false, false,
-                       false, "date_entered DESC", 0, $_SESSION["uid"], $filter);
+                       "date_entered DESC", 0, $_SESSION["uid"], $filter);
 
                $result = $qfh_ret[0];
 
@@ -91,7 +130,14 @@ class Pref_Filters extends Handler_Protected {
 
                if ($found == 0) {
                        print "<tr><td align='center'>" .
-                               __("No recent articles matching this filter have been found.") . "</td></tr>";
+                               __("No recent articles matching this filter have been found.");
+
+                       print "</td></tr><tr><td class='insensitive' align='center'>";
+
+                       print __("Complex expressions might not give results while testing due to issues with database server regexp implementation.");
+
+                       print "</td></tr>";
+
                }
 
                print "</table></div>";
@@ -123,7 +169,7 @@ class Pref_Filters extends Handler_Protected {
                        (SELECT reg_exp FROM ttrss_filters2_rules
                                WHERE filter_id = ttrss_filters2.id ORDER BY id LIMIT 1) AS reg_exp
                        FROM ttrss_filters2 WHERE
-                       owner_uid = ".$_SESSION["uid"]." ORDER BY action_id,reg_exp");
+                       owner_uid = ".$_SESSION["uid"]." ORDER BY order_id");
 
 
                $action_id = -1;
@@ -132,7 +178,7 @@ class Pref_Filters extends Handler_Protected {
 
                while ($line = db_fetch_assoc($result)) {
 
-                       if ($action_id != $line["action_id"]) {
+                       /* if ($action_id != $line["action_id"]) {
                                if (count($folder['items']) > 0) {
                                        array_push($root['items'], $folder);
                                }
@@ -142,7 +188,7 @@ class Pref_Filters extends Handler_Protected {
                                $folder['name'] = __($line["action_name"]);
                                $folder['items'] = array();
                                $action_id = $line["action_id"];
-                       }
+                       } */
 
                        $name = $this->getFilterName($line["id"]);
 
@@ -161,7 +207,7 @@ class Pref_Filters extends Handler_Protected {
 
                        if ($line['action_id'] == 7) {
                                $label_result = db_query($this->link, "SELECT fg_color, bg_color
-                                       FROM ttrss_labels2 WHERE caption = '".db_escape_string($line['action_param'])."' AND
+                                       FROM ttrss_labels2 WHERE caption = '".db_escape_string($this->link, $line['action_param'])."' AND
                                                owner_uid = " . $_SESSION["uid"]);
 
                                if (db_num_rows($label_result) > 0) {
@@ -185,9 +231,11 @@ class Pref_Filters extends Handler_Protected {
                        }
                }
 
-               if (count($folder['items']) > 0) {
+               /* if (count($folder['items']) > 0) {
                        array_push($root['items'], $folder);
-               }
+               } */
+
+               $root['items'] = $folder['items'];
 
                $fl = array();
                $fl['identifier'] = 'id';
@@ -200,13 +248,15 @@ class Pref_Filters extends Handler_Protected {
 
        function edit() {
 
-               $filter_id = db_escape_string($_REQUEST["id"]);
+               $filter_id = db_escape_string($this->link, $_REQUEST["id"]);
 
                $result = db_query($this->link,
                        "SELECT * FROM ttrss_filters2 WHERE id = '$filter_id' AND owner_uid = " . $_SESSION["uid"]);
 
                $enabled = sql_bool_to_bool(db_fetch_result($result, 0, "enabled"));
                $match_any_rule = sql_bool_to_bool(db_fetch_result($result, 0, "match_any_rule"));
+               $inverse = sql_bool_to_bool(db_fetch_result($result, 0, "inverse"));
+               $title = htmlspecialchars(db_fetch_result($result, 0, "title"));
 
                print "<form id=\"filter_edit_form\" onsubmit='return false'>";
 
@@ -215,6 +265,12 @@ class Pref_Filters extends Handler_Protected {
                print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"method\" value=\"editSave\">";
                print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"csrf_token\" value=\"".$_SESSION['csrf_token']."\">";
 
+               print "<div class=\"dlgSec\">".__("Caption")."</div>";
+
+               print "<input dojoType=\"dijit.form.TextBox\" style=\"width : 20em;\" name=\"title\" value=\"$title\">";
+
+               print "</div>";
+
                print "<div class=\"dlgSec\">".__("Match")."</div>";
 
                print "<div dojoType=\"dijit.Toolbar\">";
@@ -250,6 +306,7 @@ class Pref_Filters extends Handler_Protected {
                        unset($line["cat_id"]);
                        unset($line["filter_id"]);
                        unset($line["id"]);
+                       if (!sql_bool_to_bool($line["inverse"])) unset($line["inverse"]);
 
                        $data = htmlspecialchars(json_encode($line));
 
@@ -323,6 +380,15 @@ class Pref_Filters extends Handler_Protected {
                print "<br/><input dojoType=\"dijit.form.CheckBox\" type=\"checkbox\" name=\"match_any_rule\" id=\"match_any_rule\" $checked>
                                <label for=\"match_any_rule\">".__('Match any rule')."</label>";
 
+               if ($inverse) {
+                       $checked = "checked=\"1\"";
+               } else {
+                       $checked = "";
+               }
+
+               print "<br/><input dojoType=\"dijit.form.CheckBox\" type=\"checkbox\" name=\"inverse\" id=\"inverse\" $checked>
+                               <label for=\"inverse\">".__('Inverse matching')."</label>";
+
                print "<p/>";
 
                print "<div class=\"dlgButtons\">";
@@ -363,9 +429,10 @@ class Pref_Filters extends Handler_Protected {
 
                $result = db_query($this->link, "SELECT description FROM ttrss_filter_types
                        WHERE id = ".(int)$rule["filter_type"]);
-               $match_on = db_fetch_result($result, 0, "description");
+               $filter_type = db_fetch_result($result, 0, "description");
 
-               return T_sprintf("%s on %s in %s", $rule["reg_exp"], $match_on, $feed);
+               return T_sprintf("%s on %s in %s %s", strip_tags($rule["reg_exp"]),
+                       $filter_type, $feed, isset($rule["inverse"]) ? __("(inverse)") : "");
        }
 
        function printRuleName() {
@@ -396,12 +463,16 @@ class Pref_Filters extends Handler_Protected {
 
 #              print_r($_REQUEST);
 
-               $filter_id = db_escape_string($_REQUEST["id"]);
-               $enabled = checkbox_to_sql_bool(db_escape_string($_REQUEST["enabled"]));
-               $match_any_rule = checkbox_to_sql_bool(db_escape_string($_REQUEST["match_any_rule"]));
+               $filter_id = db_escape_string($this->link, $_REQUEST["id"]);
+               $enabled = checkbox_to_sql_bool(db_escape_string($this->link, $_REQUEST["enabled"]));
+               $match_any_rule = checkbox_to_sql_bool(db_escape_string($this->link, $_REQUEST["match_any_rule"]));
+               $inverse = checkbox_to_sql_bool(db_escape_string($this->link, $_REQUEST["inverse"]));
+               $title = db_escape_string($this->link, $_REQUEST["title"]);
 
                $result = db_query($this->link, "UPDATE ttrss_filters2 SET enabled = $enabled,
-                       match_any_rule = $match_any_rule
+                       match_any_rule = $match_any_rule,
+                       inverse = $inverse,
+                       title = '$title'
                        WHERE id = '$filter_id'
                        AND owner_uid = ". $_SESSION["uid"]);
 
@@ -411,7 +482,7 @@ class Pref_Filters extends Handler_Protected {
 
        function remove() {
 
-               $ids = split(",", db_escape_string($_REQUEST["ids"]));
+               $ids = split(",", db_escape_string($this->link, $_REQUEST["ids"]));
 
                foreach ($ids as $id) {
                        db_query($this->link, "DELETE FROM ttrss_filters2 WHERE id = '$id' AND owner_uid = ". $_SESSION["uid"]);
@@ -450,9 +521,11 @@ class Pref_Filters extends Handler_Protected {
                        foreach ($rules as $rule) {
                                if ($rule) {
 
-                                       $reg_exp = strip_tags(db_escape_string(trim($rule["reg_exp"])));
-                                       $filter_type = (int) db_escape_string(trim($rule["filter_type"]));
-                                       $feed_id = db_escape_string(trim($rule["feed_id"]));
+                                       $reg_exp = strip_tags(db_escape_string($this->link, trim($rule["reg_exp"])));
+                                       $inverse = isset($rule["inverse"]) ? "true" : "false";
+
+                                       $filter_type = (int) db_escape_string($this->link, trim($rule["filter_type"]));
+                                       $feed_id = db_escape_string($this->link, trim($rule["feed_id"]));
 
                                        if (strpos($feed_id, "CAT:") === 0) {
 
@@ -470,8 +543,8 @@ class Pref_Filters extends Handler_Protected {
                                        }
 
                                        $query = "INSERT INTO ttrss_filters2_rules
-                                               (filter_id, reg_exp,filter_type,feed_id,cat_id,cat_filter) VALUES
-                                               ('$filter_id', '$reg_exp', '$filter_type', $feed_id, $cat_id, $cat_filter)";
+                                               (filter_id, reg_exp,filter_type,feed_id,cat_id,cat_filter,inverse) VALUES
+                                               ('$filter_id', '$reg_exp', '$filter_type', $feed_id, $cat_id, $cat_filter, $inverse)";
 
                                        db_query($this->link, $query);
                                }
@@ -480,9 +553,9 @@ class Pref_Filters extends Handler_Protected {
                        foreach ($actions as $action) {
                                if ($action) {
 
-                                       $action_id = (int) db_escape_string($action["action_id"]);
-                                       $action_param = db_escape_string($action["action_param"]);
-                                       $action_param_label = db_escape_string($action["action_param_label"]);
+                                       $action_id = (int) db_escape_string($this->link, $action["action_id"]);
+                                       $action_param = db_escape_string($this->link, $action["action_param"]);
+                                       $action_param_label = db_escape_string($this->link, $action["action_param_label"]);
 
                                        if ($action_id == 7) {
                                                $action_param = $action_param_label;
@@ -513,14 +586,15 @@ class Pref_Filters extends Handler_Protected {
 
                $enabled = checkbox_to_sql_bool($_REQUEST["enabled"]);
                $match_any_rule = checkbox_to_sql_bool($_REQUEST["match_any_rule"]);
+               $title = db_escape_string($this->link, $_REQUEST["title"]);
 
                db_query($this->link, "BEGIN");
 
                /* create base filter */
 
                $result = db_query($this->link, "INSERT INTO ttrss_filters2
-                       (owner_uid, match_any_rule, enabled) VALUES
-                       (".$_SESSION["uid"].",$match_any_rule,$enabled)");
+                       (owner_uid, match_any_rule, enabled, title) VALUES
+                       (".$_SESSION["uid"].",$match_any_rule,$enabled, '$title')");
 
                $result = db_query($this->link, "SELECT MAX(id) AS id FROM ttrss_filters2
                        WHERE owner_uid = ".$_SESSION["uid"]);
@@ -534,13 +608,13 @@ class Pref_Filters extends Handler_Protected {
 
        function index() {
 
-               $sort = db_escape_string($_REQUEST["sort"]);
+               $sort = db_escape_string($this->link, $_REQUEST["sort"]);
 
                if (!$sort || $sort == "undefined") {
                        $sort = "reg_exp";
                }
 
-               $filter_search = db_escape_string($_REQUEST["search"]);
+               $filter_search = db_escape_string($this->link, $_REQUEST["search"]);
 
                if (array_key_exists("search", $_REQUEST)) {
                        $_SESSION["prefs_filter_search"] = $filter_search;
@@ -552,7 +626,7 @@ class Pref_Filters extends Handler_Protected {
                print "<div id=\"pref-filter-header\" dojoType=\"dijit.layout.ContentPane\" region=\"top\">";
                print "<div id=\"pref-filter-toolbar\" dojoType=\"dijit.Toolbar\">";
 
-               $filter_search = db_escape_string($_REQUEST["search"]);
+               $filter_search = db_escape_string($this->link, $_REQUEST["search"]);
 
                if (array_key_exists("search", $_REQUEST)) {
                        $_SESSION["prefs_filter_search"] = $filter_search;
@@ -585,6 +659,10 @@ class Pref_Filters extends Handler_Protected {
                print "<button dojoType=\"dijit.form.Button\" onclick=\"return editSelectedFilter()\">".
                        __('Edit')."</button> ";
 
+               print "<button dojoType=\"dijit.form.Button\" onclick=\"return resetFilterOrder()\">".
+                       __('Reset sort order')."</button> ";
+
+
                print "<button dojoType=\"dijit.form.Button\" onclick=\"return removeSelectedFilters()\">".
                        __('Remove')."</button> ";
 
@@ -601,14 +679,16 @@ class Pref_Filters extends Handler_Protected {
                <img src='images/indicator_tiny.gif'>".
                 __("Loading, please wait...")."</div>";
 
-               print "<div dojoType=\"dojo.data.ItemFileWriteStore\" jsId=\"filterStore\"
+               print "<div dojoType=\"fox.PrefFilterStore\" jsId=\"filterStore\"
                        url=\"backend.php?op=pref-filters&method=getfiltertree\">
                </div>
                <div dojoType=\"lib.CheckBoxStoreModel\" jsId=\"filterModel\" store=\"filterStore\"
-               query=\"{id:'root'}\" rootId=\"root\" rootLabel=\"Feeds\"
+                       query=\"{id:'root'}\" rootId=\"root\" rootLabel=\"Filters\"
                        childrenAttrs=\"items\" checkboxStrict=\"false\" checkboxAll=\"false\">
                </div>
                <div dojoType=\"fox.PrefFilterTree\" id=\"filterTree\"
+                       dndController=\"dijit.tree.dndSource\"
+                       betweenThreshold=\"5\"
                        model=\"filterModel\" openOnClick=\"true\">
                <script type=\"dojo/method\" event=\"onLoad\" args=\"item\">
                        Element.hide(\"filterlistLoading\");
@@ -625,6 +705,11 @@ class Pref_Filters extends Handler_Protected {
                </div>";
 
                print "</div>"; #pane
+
+               global $pluginhost;
+               $pluginhost->run_hooks($pluginhost::HOOK_PREFS_TAB,
+                       "hook_prefs_tab", "prefFilters");
+
                print "</div>"; #container
 
        }
@@ -637,6 +722,10 @@ class Pref_Filters extends Handler_Protected {
                print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"method\" value=\"add\">";
                print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"csrf_token\" value=\"".$_SESSION['csrf_token']."\">";
 
+               print "<div class=\"dlgSec\">".__("Caption")."</div>";
+
+               print "<input dojoType=\"dijit.form.TextBox\" style=\"width : 20em;\" name=\"title\" value=\"\">";
+
                print "<div class=\"dlgSec\">".__("Match")."</div>";
 
                print "<div dojoType=\"dijit.Toolbar\">";
@@ -698,10 +787,8 @@ class Pref_Filters extends Handler_Protected {
                print "<br/><input dojoType=\"dijit.form.CheckBox\" type=\"checkbox\" name=\"match_any_rule\" id=\"match_any_rule\">
                                <label for=\"match_any_rule\">".__('Match any rule')."</label>";
 
-               print "<p/>";
-
-/*             print "<input dojoType=\"dijit.form.CheckBox\" type=\"checkbox\" name=\"inverse\" id=\"inverse\">
-       <label for=\"inverse\">".__('Inverse match')."</label><hr/>"; */
+               print "<br/><input dojoType=\"dijit.form.CheckBox\" type=\"checkbox\" name=\"inverse\" id=\"inverse\">
+                               <label for=\"inverse\">".__('Inverse matching')."</label>";
 
 //             print "</div>";
 
@@ -727,10 +814,12 @@ class Pref_Filters extends Handler_Protected {
                        $reg_exp = htmlspecialchars($rule["reg_exp"]);
                        $filter_type = $rule["filter_type"];
                        $feed_id = $rule["feed_id"];
+                       $inverse_checked = isset($rule["inverse"]) ? "checked" : "";
                } else {
                        $reg_exp = "";
                        $filter_type = 1;
                        $feed_id = 0;
+                       $inverse_checked = "";
                }
 
                if (strpos($feed_id, "CAT:") === 0) {
@@ -761,6 +850,11 @@ class Pref_Filters extends Handler_Protected {
                         style=\"font-size : 16px; width : 20em;\"
                         name=\"reg_exp\" value=\"$reg_exp\"/>";
 
+               print "<hr/>";
+               print "<input id=\"filterDlg_inverse\" dojoType=\"dijit.form.CheckBox\"
+                        name=\"inverse\" $inverse_checked/>";
+               print "<label for=\"filterDlg_inverse\">".__("Inverse regular expression matching")."</label>";
+
                print "<hr/>" .  __("on field") . " ";
                print_select_hash("filter_type", $filter_type, $filter_types,
                        'dojoType="dijit.form.Select"');
@@ -794,7 +888,7 @@ class Pref_Filters extends Handler_Protected {
                $action = json_decode($_REQUEST["action"], true);
 
                if ($action) {
-                       $action_param = db_escape_string($action["action_param"]);
+                       $action_param = db_escape_string($this->link, $action["action_param"]);
                        $action_id = (int)$action["action_id"];
                } else {
                        $action_param = "";
@@ -858,28 +952,42 @@ class Pref_Filters extends Handler_Protected {
        }
 
        private function getFilterName($id) {
+
                $result = db_query($this->link,
-                       "SELECT * FROM ttrss_filters2_rules WHERE filter_id = '$id' ORDER BY id
-                       LIMIT 3");
+                       "SELECT title FROM ttrss_filters2 WHERE id = '$id'");
 
-               $titles = array();
-               $count = 0;
+               $title = db_fetch_result($result, 0, "title");
 
-               while ($line = db_fetch_assoc($result)) {
+               if (!$title) {
 
-                       if (sql_bool_to_bool($line["cat_filter"])) {
-                               unset($line["cat_filter"]);
-                               $line["feed_id"] = "CAT:" . (int)$line["cat_id"];
-                               unset($line["cat_id"]);
-                       }
+                       $result = db_query($this->link,
+                               "SELECT * FROM ttrss_filters2_rules WHERE filter_id = '$id' ORDER BY id
+                               LIMIT 3");
 
-                       if ($count < 2) {
-                               array_push($titles, $this->getRuleName($line));
-                       } else {
-                               array_push($titles, "...");
-                               break;
+                       $titles = array();
+                       $count = 0;
+
+                       while ($line = db_fetch_assoc($result)) {
+
+                               if (sql_bool_to_bool($line["cat_filter"])) {
+                                       unset($line["cat_filter"]);
+                                       $line["feed_id"] = "CAT:" . (int)$line["cat_id"];
+                                       unset($line["cat_id"]);
+                               }
+
+                               if (!sql_bool_to_bool($line["inverse"])) unset($line["inverse"]);
+
+                               if ($count < 2) {
+                                       array_push($titles, $this->getRuleName($line));
+                               } else {
+                                       array_push($titles, "...");
+                                       break;
+                               }
+                               ++$count;
                        }
-                       ++$count;
+
+                       $title = truncate_string(join(", ", $titles), 64, "...");
+
                }
 
                $result = db_query($this->link,
@@ -898,11 +1006,11 @@ class Pref_Filters extends Handler_Protected {
                        ++$count;
                }
 
-               return array(join(", ", $titles), join(", ", $actions));
+               return array($title, join(", ", $actions));
        }
 
        function join() {
-               $ids = explode(",", db_escape_string($_REQUEST["ids"]));
+               $ids = explode(",", db_escape_string($this->link, $_REQUEST["ids"]));
 
                if (count($ids) > 1) {
                        $base_id = array_shift($ids);