fix various issues reported by static analysis

[tt-rss.git] / classes / pref / users.php

diff --git a/classes/pref/users.php b/classes/pref/users.php
index 164935b234533db0d773f06734fcc93a2819bdb5..215f05646c9ad2522e2d8ae57ff71e3dc9065aed 100644 (file)
--- a/classes/pref/users.php
+++ b/classes/pref/users.php
@@ -27,9 +27,9 @@ class Pref_Users extends Handler_Protected {
 
                        $id = (int) $this->dbh->escape_string($_REQUEST["id"]);
 
-                       print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"id\" value=\"$id\">";
-                       print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"op\" value=\"pref-users\">";
-                       print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"method\" value=\"editSave\">";
+                       print_hidden("id", "$id");
+                       print_hidden("op", "pref-users");
+                       print_hidden("method", "editSave");
 
                        $result = $this->dbh->query("SELECT * FROM ttrss_users WHERE id = '$id'");
 
@@ -43,7 +43,7 @@ class Pref_Users extends Handler_Protected {
                        print "<div class=\"dlgSecCont\">";
 
                        if ($sel_disabled) {
-                               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"login\" value=\"$login\">";
+                               print_hidden("login", "$login");
                        }
 
                        print "<input size=\"30\" style=\"font-size : 16px\"
@@ -64,7 +64,7 @@ class Pref_Users extends Handler_Protected {
                        } else {
                                print_select_hash("", $access_level, $access_level_names,
                                        "dojoType=\"dijit.form.Select\" $sel_disabled");
-                               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"access_level\" value=\"$access_level\">";
+                               print_hidden("access_level", "$access_level");
                        }
 
                        print "<hr/>";
@@ -251,7 +251,6 @@ class Pref_Users extends Handler_Protected {
 
                        $login = db_fetch_result($result, 0, "login");
                        $email = db_fetch_result($result, 0, "email");
-                       $salt = db_fetch_result($result, 0, "salt");
 
                        $new_salt = substr(bin2hex(get_random_bytes(125)), 0, 250);
                        $tmp_user_pwd = make_password(8);