af_zz_imgproxy: implement a whitelist of known sites that have optional SSL

[tt-rss.git] / plugins / af_zz_imgproxy / init.php

diff --git a/plugins/af_zz_imgproxy/init.php b/plugins/af_zz_imgproxy/init.php
index 67ca6c30f6718fb74eba0b714313291937de2d72..43b3fe7f1715eeabe50400e35171272514e17d1a 100644 (file)
--- a/plugins/af_zz_imgproxy/init.php
+++ b/plugins/af_zz_imgproxy/init.php
@@ -8,30 +8,47 @@ class Af_Zz_ImgProxy extends Plugin {
                        "fox");
        }
 
+       private $ssl_known_whitelist = "imgur.com i.reddituploads.com pbs.twimg.com i.redd.it i.sli.mg media.tumblr.com";
+
+       function is_public_method($method) {
+               return $method === "imgproxy";
+       }
+
        function init($host) {
                $this->host = $host;
 
                $host->add_hook($host::HOOK_RENDER_ARTICLE, $this);
                $host->add_hook($host::HOOK_RENDER_ARTICLE_CDM, $this);
-               $host->add_hook($host::HOOK_RENDER_ARTICLE_API, $this);
+               $host->add_hook($host::HOOK_ENCLOSURE_ENTRY, $this);
 
                $host->add_hook($host::HOOK_PREFS_TAB, $this);
        }
 
-       function hook_render_article($article) {
-               return $this->hook_render_article_cdm($article);
+       function hook_enclosure_entry($enc) {
+               if (preg_match("/image/", $enc["content_type"])) {
+                       $proxy_all = $this->host->get($this, "proxy_all");
+
+                       $enc["content_url"] = $this->rewrite_url_if_needed($enc["content_url"], $proxy_all);
+               }
+
+               return $enc;
        }
 
-       function hook_render_article_api($headline) {
-               return $this->hook_render_article_cdm($headline["headline"], true);
+       function hook_render_article($article) {
+               return $this->hook_render_article_cdm($article);
        }
 
        public function imgproxy() {
+
                $url = rewrite_relative_url(SELF_URL_PATH, $_REQUEST["url"]);
-               $kind = (int) $_REQUEST["kind"]; // 1 = video
 
-               $extension = $kind == 1 ? '.mp4' : '.png';
-               $local_filename = CACHE_DIR . "/images/" . sha1($url) . $extension;
+               // called without user context, let's just redirect to original URL
+               if (!$_SESSION["uid"]) {
+                       header("Location: $url");
+                       return;
+               }
+
+               $local_filename = CACHE_DIR . "/images/" . sha1($url);
 
                if ($_REQUEST["debug"] == "1") { print $url . "\n" . $local_filename; die; }
 
@@ -48,9 +65,6 @@ class Af_Zz_ImgProxy extends Plugin {
                } else {
                        $data = fetch_file_contents(array("url" => $url));
 
-                       global $fetch_last_error;
-                       print $fetch_last_error;
-
                        if ($data) {
                                if (file_put_contents($local_filename, $data)) {
                                        $mimetype = mime_content_type($local_filename);
@@ -58,11 +72,42 @@ class Af_Zz_ImgProxy extends Plugin {
                                }
 
                                print $data;
+                       } else {
+                               global $fetch_last_error;
+                               global $fetch_last_error_code;
+                               global $fetch_last_error_content;
+
+                               if (function_exists("imagecreate") && !isset($_REQUEST["text"])) {
+                                       $img = imagecreate(450, 75);
+
+                                       $bg = imagecolorallocate($img, 255, 255, 255);
+                                       $textcolor = imagecolorallocate($img, 255, 0, 0);
+
+                                       imagerectangle($img, 0, 0, 450-1, 75-1, $textcolor);
+
+                                       imagestring($img, 5, 5, 5, "Proxy request failed", $textcolor);
+                                       imagestring($img, 5, 5, 30, truncate_middle($url, 46, "..."), $textcolor);
+                                       imagestring($img, 5, 5, 55, "HTTP Code: $fetch_last_error_code", $textcolor);
+
+                                       header("Content-type: image/png");
+                                       print imagepng($img);
+                                       imagedestroy($img);
+
+                               } else {
+                                       header("Content-type: text/html");
+
+                                       http_response_code(400);
+
+                                       print "<h1>Proxy request failed.</h1>";
+                                       print "<p>Fetch error $fetch_last_error ($fetch_last_error_code)</p>";
+                                       print "<p>URL: $url</p>";
+                                       print "<textarea cols='80' rows='25'>" . htmlspecialchars($fetch_last_error_content) . "</textarea>";
+                               }
                        }
                }
        }
 
-       function rewrite_url_if_needed($url, $kind, $all_remote = false) {
+       function rewrite_url_if_needed($url, $all_remote = false) {
                $scheme = parse_url($url, PHP_URL_SCHEME);
 
                if ($all_remote) {
@@ -76,7 +121,17 @@ class Af_Zz_ImgProxy extends Plugin {
 
                if (($scheme != 'https' && $scheme != "") || $is_remote) {
                        if (strpos($url, "data:") !== 0) {
-                               $url = "backend.php?op=pluginhandler&plugin=af_zz_imgproxy&method=imgproxy&kind=$kind&url=" .
+                               $parts = parse_url($url);
+
+                               foreach (explode(" " , $this->ssl_known_whitelist) as $host) {
+                                       if (strpos($parts['host'], $host) !== FALSE) {
+                                               $parts['scheme'] = 'https';
+
+                                               return build_url($parts);
+                                       }
+                               }
+
+                               return get_self_url_prefix() . "/public.php?op=pluginhandler&plugin=af_zz_imgproxy&pmethod=imgproxy&url=" .
                                        urlencode($url);
                        }
                }
@@ -95,10 +150,11 @@ class Af_Zz_ImgProxy extends Plugin {
                        $imgs = $xpath->query("//img[@src]");
 
                        foreach ($imgs as $img) {
-                               $new_src = $this->rewrite_url_if_needed($img->getAttribute("src"), 0, $proxy_all);
+                               $new_src = $this->rewrite_url_if_needed($img->getAttribute("src"), $proxy_all);
 
                                if ($new_src != $img->getAttribute("src")) {
                                        $img->setAttribute("src", $new_src);
+                                       $img->removeAttribute("srcset");
 
                                        $need_saving = true;
                                }
@@ -108,7 +164,7 @@ class Af_Zz_ImgProxy extends Plugin {
 
                        foreach ($vids as $vid) {
                                if ($vid->hasAttribute("poster")) {
-                                       $new_src = $this->rewrite_url_if_needed($vid->getAttribute("poster"), 0, $proxy_all);
+                                       $new_src = $this->rewrite_url_if_needed($vid->getAttribute("poster"), $proxy_all);
 
                                        if ($new_src != $vid->getAttribute("poster")) {
                                                $vid->setAttribute("poster", $new_src);
@@ -120,7 +176,7 @@ class Af_Zz_ImgProxy extends Plugin {
                                $vsrcs = $xpath->query("source", $vid);
 
                                foreach ($vsrcs as $vsrc) {
-                                       $new_src = $this->rewrite_url_if_needed($vsrc->getAttribute("src"), 1, $proxy_all);
+                                       $new_src = $this->rewrite_url_if_needed($vsrc->getAttribute("src"), $proxy_all);
 
                                        if ($new_src != $vsrc->getAttribute("src")) {
                                                $vid->setAttribute("src", $new_src);
@@ -139,7 +195,7 @@ class Af_Zz_ImgProxy extends Plugin {
        function hook_prefs_tab($args) {
                if ($args != "prefFeeds") return;
 
-               print "<div dojoType=\"dijit.layout.AccordionPane\" title=\"".__('af_zz_imgproxy Settings')."\">";
+               print "<div dojoType=\"dijit.layout.AccordionPane\" title=\"".__('Image proxy settings (af_zz_imgproxy)')."\">";
 
                print "<form dojoType=\"dijit.form.Form\">";