]> git.wh0rd.org - tt-rss.git/blobdiff - plugins/import_export/init.php
plugins/import_export: use PDO
[tt-rss.git] / plugins / import_export / init.php
old mode 100644 (file)
new mode 100755 (executable)
index b6693f0..e7e036f
@@ -4,6 +4,7 @@ class Import_Export extends Plugin implements IHandler {
 
        function init($host) {
                $this->host = $host;
+               $this->pdo = Db::pdo();
 
                $host->add_hook($host::HOOK_PREFS_TAB, $this);
                $host->add_command("xml-import", "import articles from XML", $this, ":", "FILE");
@@ -15,6 +16,10 @@ class Import_Export extends Plugin implements IHandler {
                        "fox");
        }
 
+       private function bool_to_sql_bool($s) {
+               return $s ? 'true' : 'false';
+       }
+
        function xml_import($args) {
 
                $filename = $args['xml_import'];
@@ -30,14 +35,15 @@ class Import_Export extends Plugin implements IHandler {
 
                _debug("importing $filename for user $username...\n");
 
-               $result = db_query("SELECT id FROM ttrss_users WHERE login = '$username'");
+               $sth = $this->pdo->prepare("SELECT id FROM ttrss_users WHERE login = ?");
+               $sth->execute([$username]);
 
-               if (db_num_rows($result) == 0) {
+               if ($sth->rowCount() == 0) {
                        print "error: could not find user $username.\n";
                        return;
                }
 
-               $owner_uid = db_fetch_result($result, 0, "id");
+               $owner_uid = $sth->fetchColumn(0);
 
                $this->perform_data_import($filename, $owner_uid);
        }
@@ -91,6 +97,9 @@ class Import_Export extends Plugin implements IHandler {
                return in_array($method, array("exportget"));
        }
 
+       /**
+        * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+        */
        function before($method) {
                return $_SESSION["uid"] != false;
        }
@@ -99,6 +108,9 @@ class Import_Export extends Plugin implements IHandler {
                return true;
        }
 
+       /**
+        * @SuppressWarnings(unused)
+        */
        function exportget() {
                $exportname = CACHE_DIR . "/export/" .
                        sha1($_SESSION['uid'] . $_SESSION['login']) . ".xml";
@@ -121,12 +133,12 @@ class Import_Export extends Plugin implements IHandler {
        }
 
        function exportrun() {
-               $offset = (int) db_escape_string($_REQUEST['offset']);
+               $offset = (int) $_REQUEST['offset'];
                $exported = 0;
                $limit = 250;
 
                if ($offset < 10000 && is_writable(CACHE_DIR . "/export")) {
-                       $result = db_query("SELECT
+                       $sth = $this->pdo->prepare("SELECT
                                        ttrss_entries.guid,
                                        ttrss_entries.title,
                                        content,
@@ -146,8 +158,9 @@ class Import_Export extends Plugin implements IHandler {
                                WHERE
                                        (marked = true OR feed_id IS NULL) AND
                                        ref_id = ttrss_entries.id AND
-                                       ttrss_user_entries.owner_uid = " . $_SESSION['uid'] . "
-                               ORDER BY ttrss_entries.id LIMIT $limit OFFSET $offset");
+                                       ttrss_user_entries.owner_uid = ?
+                               ORDER BY ttrss_entries.id LIMIT ? OFFSET ?");
+                       $sth->execute([$_SESSION['uid'], $limit, $offset]);
 
                        $exportname = sha1($_SESSION['uid'] . $_SESSION['login']);
 
@@ -160,7 +173,7 @@ class Import_Export extends Plugin implements IHandler {
 
                        if ($fp) {
 
-                               while ($line = db_fetch_assoc($result)) {
+                               while ($line = $sth->fetch(PDO::FETCH_ASSOC)) {
                                        fputs($fp, "<article>");
 
                                        foreach ($line as $k => $v) {
@@ -171,7 +184,7 @@ class Import_Export extends Plugin implements IHandler {
                                        fputs($fp, "</article>");
                                }
 
-                               $exported = db_num_rows($result);
+                               $exported = $sth->rowCount();
 
                                if ($exported < $limit && $exported > 0) {
                                        fputs($fp, "</articles>");
@@ -241,10 +254,13 @@ class Import_Export extends Plugin implements IHandler {
                                        $article = array();
 
                                        foreach ($article_node->childNodes as $child) {
-                                               if ($child->nodeName != 'label_cache')
-                                                       $article[$child->nodeName] = db_escape_string($child->nodeValue);
-                                               else
+                                               if ($child->nodeName == 'content') {
+                                                       $article[$child->nodeName] = db_escape_string($child->nodeValue, false);
+                                               } else if ($child->nodeName == 'label_cache') {
                                                        $article[$child->nodeName] = $child->nodeValue;
+                                               } else {
+                                                       $article[$child->nodeName] = db_escape_string($child->nodeValue);
+                                               }
                                        }
 
                                        //print_r($article);
@@ -257,12 +273,13 @@ class Import_Export extends Plugin implements IHandler {
 
                                                //print 'GUID:' . $article['guid'] . "\n";
 
-                                               $result = db_query("SELECT id FROM ttrss_entries
-                                                       WHERE guid = '".$article['guid']."'");
+                                               $sth = $this->pdo->prepare("SELECT id FROM ttrss_entries
+                                                       WHERE guid = ?");
+                                               $sth->execute([$article['guid']]);
 
-                                               if (db_num_rows($result) == 0) {
+                                               if ($sth->rowCount() == 0) {
 
-                                                       $result = db_query(
+                                                       $sth = $this->pdo->prepare(
                                                                "INSERT INTO ttrss_entries
                                                                        (title,
                                                                        guid,
@@ -277,28 +294,37 @@ class Import_Export extends Plugin implements IHandler {
                                                                        num_comments,
                                                                        author)
                                                                VALUES
-                                                                       ('".$article['title']."',
-                                                                       '".$article['guid']."',
-                                                                       '".$article['link']."',
-                                                                       '".$article['updated']."',
-                                                                       '".$article['content']."',
-                                                                       '".sha1($article['content'])."',
+                                                                       (?,
+                                                                       ?,
+                                                                       ?,
+                                                                       ?,
+                                                                       ?,
+                                                                       ?,
                                                                        false,
                                                                        NOW(),
                                                                        NOW(),
                                                                        '',
                                                                        '0',
                                                                        '')");
-
-                                                       $result = db_query("SELECT id FROM ttrss_entries
-                                                               WHERE guid = '".$article['guid']."'");
-
-                                                       if (db_num_rows($result) != 0) {
-                                                               $ref_id = db_fetch_result($result, 0, "id");
+                                                       $sth->execute([
+                                                               $article['title'],
+                                                               $article['guid'],
+                                                               $article['link'],
+                                                               $article['updated'],
+                                                               $article['content'],
+                                                               sha1($article['content'])
+                                                       ]);
+
+                                                       $sth = $this->pdo->prepare("SELECT id FROM ttrss_entries
+                                                               WHERE guid = ?");
+                                                       $sth->execute([$article['guid']]);
+
+                                                       if ($sth->rowCount() != 0) {
+                                                               $ref_id = $sth->fetchColumn(0);
                                                        }
 
                                                } else {
-                                                       $ref_id = db_fetch_result($result, 0, "id");
+                                                       $ref_id = $sth->fetchColumn(0);
                                                }
 
                                                //print "Got ref ID: $ref_id\n";
@@ -311,24 +337,27 @@ class Import_Export extends Plugin implements IHandler {
                                                        $feed = 'NULL';
 
                                                        if ($feed_url && $feed_title) {
-                                                               $result = db_query("SELECT id FROM ttrss_feeds
-                                                                       WHERE feed_url = '$feed_url' AND owner_uid = '$owner_uid'");
+                                                               $sth = $this->pdo->prepare("SELECT id FROM ttrss_feeds
+                                                                       WHERE feed_url = ? AND owner_uid = ?");
+                                                               $sth->execute([$feed_url, $owner_uid]);
 
-                                                               if (db_num_rows($result) != 0) {
-                                                                       $feed = db_fetch_result($result, 0, "id");
+                                                               if ($sth->rowCount() != 0) {
+                                                                       $feed = $sth->fetchColumn(0);
                                                                } else {
                                                                        // try autocreating feed in Uncategorized...
 
-                                                                       $result = db_query("INSERT INTO ttrss_feeds (owner_uid,
-                                                                               feed_url, title) VALUES ($owner_uid, '$feed_url', '$feed_title')");
+                                                                       $sth = $this->pdo->prepare("INSERT INTO ttrss_feeds (owner_uid,
+                                                                               feed_url, title) VALUES (?, ?, ?)");
+                                                                       $sth->execute([$owner_uid, $feed_url, $feed_title]);
 
-                                                                       $result = db_query("SELECT id FROM ttrss_feeds
-                                                                               WHERE feed_url = '$feed_url' AND owner_uid = '$owner_uid'");
+                                                                       $sth = $this->pdo->prepare("SELECT id FROM ttrss_feeds
+                                                                               WHERE feed_url = ? AND owner_uid = ?");
+                                                                       $sth->execute([$feed_url, $owner_uid]);
 
-                                                                       if (db_num_rows($result) != 0) {
+                                                                       if ($sth->rowCount() != 0) {
                                                                                ++$num_feeds_created;
 
-                                                                               $feed = db_fetch_result($result, 0, "id");
+                                                                               $feed = $sth->fetchColumn(0);
                                                                        }
                                                                }
                                                        }
@@ -340,40 +369,41 @@ class Import_Export extends Plugin implements IHandler {
 
                                                        //print "$ref_id / $feed / " . $article['title'] . "\n";
 
-                                                       $result = db_query("SELECT int_id FROM ttrss_user_entries
-                                                               WHERE ref_id = '$ref_id' AND owner_uid = '$owner_uid' AND $feed_qpart");
+                                                       $sth = $this->pdo->prepare("SELECT int_id FROM ttrss_user_entries
+                                                               WHERE ref_id = ? AND owner_uid = ? AND ?");
+                                                       $sth->execute([$ref_id, $owner_uid, $feed_qpart]);
 
-                                                       if (db_num_rows($result) == 0) {
+                                                       if ($sth->rowCount() == 0) {
 
-                                                               $marked = bool_to_sql_bool(sql_bool_to_bool($article['marked']));
-                                                               $published = bool_to_sql_bool(sql_bool_to_bool($article['published']));
+                                                               $marked = $this->bool_to_sql_bool(sql_bool_to_bool($article['marked']));
+                                                               $published = $this->bool_to_sql_bool(sql_bool_to_bool($article['published']));
                                                                $score = (int) $article['score'];
 
                                                                $tag_cache = $article['tag_cache'];
-                                                               $label_cache = db_escape_string($article['label_cache']);
                                                                $note = $article['note'];
 
                                                                //print "Importing " . $article['title'] . "<br/>";
 
                                                                ++$num_imported;
 
-                                                               $result = db_query(
+                                                               $sth = $this->pdo->prepare(
                                                                        "INSERT INTO ttrss_user_entries
                                                                        (ref_id, owner_uid, feed_id, unread, last_read, marked,
                                                                                published, score, tag_cache, label_cache, uuid, note)
-                                                                       VALUES ($ref_id, $owner_uid, $feed, false,
-                                                                               NULL, $marked, $published, $score, '$tag_cache',
-                                                                                       '$label_cache', '', '$note')");
+                                                                       VALUES (?, ?, ?, false,
+                                                                               NULL, ?, ?, ?, ?,
+                                                                                       '', '', ?)");
+                                                               $sth->execute([$ref_id, $owner_uid, $feed, $marked, $published, $score, $tag_cache, $note]);
 
-                                                               $label_cache = json_decode($label_cache, true);
+                                                               $label_cache = json_decode($article['label_cache'], true);
 
                                                                if (is_array($label_cache) && $label_cache["no-labels"] != 1) {
                                                                        foreach ($label_cache as $label) {
 
-                                                                               label_create($label[1],
+                                                                               Labels::create($label[1],
                                                                                        $label[2], $label[3], $owner_uid);
 
-                                                                               label_add_article($ref_id, $label[1], $owner_uid);
+                                                                               Labels::add_article($ref_id, $label[1], $owner_uid);
 
                                                                        }
                                                                }
@@ -423,34 +453,35 @@ class Import_Export extends Plugin implements IHandler {
                print "<div style='text-align : center'>";
 
                if ($_FILES['export_file']['error'] != 0) {
-                       print_error(T_sprintf("Upload failed with error code %d",
-                               $_FILES['export_file']['error']));
-                       return;
-               }
+                       print_error(T_sprintf("Upload failed with error code %d (%s)",
+                               $_FILES['export_file']['error'],
+                               get_upload_error_message($_FILES['export_file']['error'])));
+               } else {
 
-               $tmp_file = false;
+                       $tmp_file = false;
 
-               if (is_uploaded_file($_FILES['export_file']['tmp_name'])) {
-                       $tmp_file = tempnam(CACHE_DIR . '/upload', 'export');
+                       if (is_uploaded_file($_FILES['export_file']['tmp_name'])) {
+                               $tmp_file = tempnam(CACHE_DIR . '/upload', 'export');
 
-                       $result = move_uploaded_file($_FILES['export_file']['tmp_name'],
-                               $tmp_file);
+                               $result = move_uploaded_file($_FILES['export_file']['tmp_name'],
+                                       $tmp_file);
 
-                       if (!$result) {
-                               print_error(__("Unable to move uploaded file."));
+                               if (!$result) {
+                                       print_error(__("Unable to move uploaded file."));
+                                       return;
+                               }
+                       } else {
+                               print_error(__('Error: please upload OPML file.'));
                                return;
                        }
-               } else {
-                       print_error(__('Error: please upload OPML file.'));
-                       return;
-               }
 
-               if (is_file($tmp_file)) {
-                       $this->perform_data_import($tmp_file, $_SESSION['uid']);
-                       unlink($tmp_file);
-               } else {
-                       print_error(__('No file uploaded.'));
-                       return;
+                       if (is_file($tmp_file)) {
+                               $this->perform_data_import($tmp_file, $_SESSION['uid']);
+                               unlink($tmp_file);
+                       } else {
+                               print_error(__('No file uploaded.'));
+                               return;
+                       }
                }
 
                print "<button dojoType=\"dijit.form.Button\"
@@ -466,4 +497,3 @@ class Import_Export extends Plugin implements IHandler {
        }
 
 }
-?>