update phpmd ruleset to use (subset) of cleancode

[tt-rss.git] / plugins / mail / init.php

diff --git a/plugins/mail/init.php b/plugins/mail/init.php
index 4b1989f5fab983ff5aa37a27de0b3b1e25fe34ed..5fa8c8e1ce159c601cecaab94338d45401b3acfb 100644 (file)
--- a/plugins/mail/init.php
+++ b/plugins/mail/init.php
@@ -51,9 +51,9 @@ class Mail extends Plugin {
                        }
                        </script>";
 
-                       print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"op\" value=\"pluginhandler\">";
-                       print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"method\" value=\"save\">";
-                       print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"plugin\" value=\"mail\">";
+                       print_hidden("op", "pluginhandler");
+                       print_hidden("method", "save");
+                       print_hidden("plugin", "mail");
 
                        $addresslist = $this->host->get($this, "addresslist");
 
@@ -79,9 +79,9 @@ class Mail extends Plugin {
 
                $param = db_escape_string($_REQUEST['param']);
 
-               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"op\" value=\"pluginhandler\">";
-               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"plugin\" value=\"mail\">";
-               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"method\" value=\"sendEmail\">";
+               print_hidden("op", "pluginhandler");
+               print_hidden("plugin", "mail");
+               print_hidden("method", "sendEmail");
 
                $result = db_query("SELECT email, full_name FROM ttrss_users WHERE
                        id = " . $_SESSION["uid"]);
@@ -91,8 +91,8 @@ class Mail extends Plugin {
 
                if (!$user_name) $user_name = $_SESSION['name'];
 
-               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"from_email\" value=\"$user_email\">";
-               print "<input dojoType=\"dijit.form.TextBox\" style=\"display : none\" name=\"from_name\" value=\"$user_name\">";
+               print_hidden("from_email", "$user_email");
+               print_hidden("from_name", "$user_name");
 
                require_once "lib/MiniTemplator.class.php";
 
@@ -145,7 +145,7 @@ class Mail extends Plugin {
                                style=\"width : 30em;\"
                                name=\"destination\" id=\"emailArticleDlg_destination\">"; */
 
-               print_select("destination", "", $addresslist, 'style="width: 30em" dojoType="dijit.form.FilteringSelect"');
+               print_select("destination", "", $addresslist, 'style="width: 30em" dojoType="dijit.form.ComboBox"');
 
 /*             print "<div class=\"autocomplete\" id=\"emailArticleDlg_dst_choices\"
        style=\"z-index: 30; display : none\"></div>"; */
@@ -162,7 +162,8 @@ class Mail extends Plugin {
 
                print "</td></tr>";
 
-               print "<tr><td colspan='2'><textarea dojoType=\"dijit.form.SimpleTextarea\" style='font-size : 12px; width : 100%' rows=\"20\"
+               print "<tr><td colspan='2'><textarea dojoType=\"dijit.form.SimpleTextarea\" 
+                       style='height : 200px; font-size : 12px; width : 98%' rows=\"20\"
                        name='content'>$content</textarea>";
 
                print "</td></tr></table>";
@@ -223,5 +224,4 @@ class Mail extends Plugin {
                return 2;
        }
 
-}
-?>
+}
\ No newline at end of file