]> git.wh0rd.org - tt-rss.git/blobdiff - prefs.js
add sanity check & debug mode to prefs; misc code cleanups
[tt-rss.git] / prefs.js
index 04c5266b6755c6c6107d27961bcf5180f7e9fa47..eed755d5afd830d48a2fe8645bb8c22569738311 100644 (file)
--- a/prefs.js
+++ b/prefs.js
@@ -1,34 +1,16 @@
 var xmlhttp = false;
 
-var active_feed = false;
 var active_feed_cat = false;
-var active_filter = false;
 var active_label = false;
-var active_user = false;
 var active_tab = false;
 var feed_to_expand = false;
 
 var piggie_top = -400;
 var piggie_fwd = true;
 
-/*@cc_on @*/
-/*@if (@_jscript_version >= 5)
-// JScript gives us Conditional compilation, we can cope with old IE versions.
-// and security blocked creation of the objects.
-try {
-       xmlhttp = new ActiveXObject("Msxml2.XMLHTTP");
-} catch (e) {
-       try {
-               xmlhttp = new ActiveXObject("Microsoft.XMLHTTP");
-       } catch (E) {
-               xmlhttp = false;
-       }
-}
-@end @*/
+var xmlhttp = Ajax.getTransport();
 
-if (!xmlhttp && typeof XMLHttpRequest!='undefined') {
-       xmlhttp = new XMLHttpRequest();
-}
+var init_params = new Array();
 
 function expand_feed_callback() {
        if (xmlhttp.readyState == 4) {
@@ -50,18 +32,19 @@ function feedlist_callback() {
                        container.innerHTML=xmlhttp.responseText;
                        selectTab("feedConfig", true);
 
-                       if (active_feed) {
-                               var row = document.getElementById("FEEDR-" + active_feed);
+                       if (active_feed_cat) {
+                               var row = document.getElementById("FCATR-" + active_feed_cat);
                                if (row) {
                                        if (!row.className.match("Selected")) {
                                                row.className = row.className + "Selected";
                                        }               
                                }
-                               var checkbox = document.getElementById("FRCHK-" + active_feed);
+                               var checkbox = document.getElementById("FCCHK-" + active_feed_cat);
                                if (checkbox) {
                                        checkbox.checked = true;
                                }
                        }
+
                        notify("");
                } catch (e) {
                        exception_error("feedlist_callback", e);
@@ -72,22 +55,7 @@ function feedlist_callback() {
 function filterlist_callback() {
        var container = document.getElementById('prefContent');
        if (xmlhttp.readyState == 4) {
-
                container.innerHTML=xmlhttp.responseText;
-
-               if (active_filter) {
-                       var row = document.getElementById("FILRR-" + active_filter);
-                       if (row) {
-                               if (!row.className.match("Selected")) {
-                                       row.className = row.className + "Selected";
-                               }               
-                       }
-                       var checkbox = document.getElementById("FICHK-" + active_filter);
-                       
-                       if (checkbox) {
-                               checkbox.checked = true;
-                       }
-               }
                notify("");
        }
 }
@@ -126,20 +94,6 @@ function userlist_callback() {
        var container = document.getElementById('prefContent');
        if (xmlhttp.readyState == 4) {
                container.innerHTML=xmlhttp.responseText;
-
-               if (active_user) {
-                       var row = document.getElementById("UMRR-" + active_user);
-                       if (row) {
-                               if (!row.className.match("Selected")) {
-                                       row.className = row.className + "Selected";
-                               }               
-                       }
-                       var checkbox = document.getElementById("UMCHK-" + active_user);
-                       
-                       if (checkbox) {
-                               checkbox.checked = true;
-                       }
-               } 
                notify("");
        }
 }
@@ -286,7 +240,7 @@ function addFeed() {
        } else {
                notify("Adding feed...");
 
-               xmlhttp.open("GET", "backend.php?op=pref-feeds&subop=add&link=" +
+               xmlhttp.open("GET", "backend.php?op=pref-feeds&subop=add&feed_url=" +
                        param_escape(link.value), true);
                xmlhttp.onreadystatechange=feedlist_callback;
                xmlhttp.send(null);
@@ -369,11 +323,12 @@ function editUser(id) {
                return
        }
 
-       active_user = id;
+       selectTableRowsByIdPrefix('prefUserList', 'UMRR-', 'UMCHK-', false);
+       selectTableRowById('UMRR-'+id, 'UMCHK-'+id, true);
 
        xmlhttp.open("GET", "backend.php?op=pref-users&subop=edit&id=" +
                param_escape(id), true);
-       xmlhttp.onreadystatechange=userlist_callback;
+       xmlhttp.onreadystatechange=infobox_callback;
        xmlhttp.send(null);
 
 }
@@ -385,13 +340,14 @@ function editFilter(id) {
                return
        }
 
-       active_filter = id;
+       document.getElementById("create_filter_btn").disabled = true;
 
-       xmlhttp.open("GET", "backend.php?op=pref-filters&subop=edit&id=" +
-               param_escape(id), true);
-       xmlhttp.onreadystatechange=filterlist_callback;
-       xmlhttp.send(null);
+       selectTableRowsByIdPrefix('prefFilterList', 'FILRR-', 'FICHK-', false);
+       selectTableRowById('FILRR-'+id, 'FICHK-'+id, true);
 
+       xmlhttp.open("GET", "backend.php?op=pref-filters&subop=edit&id=" + param_escape(id), true);
+       xmlhttp.onreadystatechange=infobox_callback;
+       xmlhttp.send(null);
 }
 
 function editFeed(feed) {
@@ -403,21 +359,12 @@ function editFeed(feed) {
                return
        }
 
-       active_feed = feed;
-
-/*     xmlhttp.open("GET", "backend.php?op=pref-feeds&subop=edit&id=" +
-               param_escape(feed), true);
-       xmlhttp.onreadystatechange=feedlist_callback;
-       xmlhttp.send(null); */
-
+       // clean selection from all rows & select row being edited
        selectTableRowsByIdPrefix('prefFeedList', 'FEEDR-', 'FRCHK-', false);
-//     selectTableRowsByIdPrefix('prefFeedList', 'FEEDR-'+feed, 'FRCHK-'+feed, 
-//             true, false);
-
        selectTableRowById('FEEDR-'+feed, 'FRCHK-'+feed, true);
 
        xmlhttp.open("GET", "backend.php?op=pref-feeds&subop=editfeed&id=" +
-               param_escape(active_feed), true);
+               param_escape(feed), true);
 
        xmlhttp.onreadystatechange=infobox_callback;
        xmlhttp.send(null);
@@ -483,38 +430,6 @@ function getSelectedFeedsFromBrowser() {
        return selected;
 }
 
-
-/*function readSelectedFeeds(read) {
-
-       if (!xmlhttp_ready(xmlhttp)) {
-               printLockingError();
-               return
-       }
-
-       var sel_rows = getSelectedFeeds();
-
-       if (sel_rows.length > 0) {
-
-               if (!read) {
-                       op = "unread";
-               } else {
-                       op = "read";
-               }
-
-               notify("Marking selected feeds as " + op + "...");
-
-               xmlhttp.open("GET", "backend.php?op=pref-rpc&subop=" + op + "&ids="+
-                       param_escape(sel_rows.toString()), true);
-               xmlhttp.onreadystatechange=notify_callback;
-               xmlhttp.send(null);
-
-       } else {
-
-               alert("No feeds are selected.");
-
-       }
-} */
-
 function removeSelectedLabels() {
 
        if (!xmlhttp_ready(xmlhttp)) {
@@ -665,13 +580,7 @@ function feedEditCancel() {
 
        closeInfoBox();
 
-       active_feed = false;
-
-//     notify("Operation cancelled.");
-
-/*     xmlhttp.open("GET", "backend.php?op=pref-feeds", true);
-       xmlhttp.onreadystatechange=feedlist_callback;
-       xmlhttp.send(null); */
+       selectPrefRows('feed', false); // cleanup feed selection
 
 }
 
@@ -695,80 +604,27 @@ function feedCatEditCancel() {
 function feedEditSave() {
 
        try {
-
-               var feed = active_feed;
        
                if (!xmlhttp_ready(xmlhttp)) {
                        printLockingError();
                        return
                }
-       
-               var link = document.getElementById("iedit_link").value;
-               var title = document.getElementById("iedit_title").value;
-               var upd_intl = document.getElementById("iedit_updintl");
-
-               upd_intl = upd_intl[upd_intl.selectedIndex].id;
-                       
-               var purge_intl = document.getElementById("iedit_purgintl");
-
-               purge_intl = purge_intl[purge_intl.selectedIndex].id;
-               
-               var fcat = document.getElementById("iedit_fcat");
-
-               var is_pvt = document.getElementById("iedit_private");
-               var is_rtl = document.getElementById("iedit_rtl");
-
-               if (is_pvt) {
-                       is_pvt = is_pvt.checked;
-               }
 
-               if (is_rtl) {
-                       is_rtl = is_rtl.checked;
-               }
+               // FIXME: add parameter validation
 
-               var fcat_id = 0;
-       
-               if (fcat) {     
-                       fcat_id = fcat[fcat.selectedIndex].id;
-               }
+               var query = Form.serialize("edit_feed_form");
 
-               var pfeed = document.getElementById("iedit_parent_feed");
-               var parent_feed_id = pfeed[pfeed.selectedIndex].id;
-       
-               if (link.length == 0) {
-                       notify("Feed link cannot be blank.");
-                       return;
-               }
-       
-               if (title.length == 0) {
-                       notify("Feed title cannot be blank.");
-                       return;
-               }
-
-               if (!isValidURL(link)) {
-                       alert("Feed URL is invalid.");
-                       return;
-               }
-       
-               var auth_login = document.getElementById("iedit_login").value;
-               var auth_pass = document.getElementById("iedit_pass").value;
-       
-               active_feed = false;
-       
                notify("Saving feed...");
 
-               var query = "op=pref-feeds&subop=editSave&id=" +
-                       feed + "&l=" + param_escape(link) + "&t=" + param_escape(title) +
-                       "&ui=" + param_escape(upd_intl) + "&pi=" + param_escape(purge_intl) +
-                       "&catid=" + param_escape(fcat_id) + "&login=" + param_escape(auth_login) +                      
-                       "&pfeed=" + param_escape(parent_feed_id) + "&pass=" + param_escape(auth_pass) +
-                       "&is_pvt=" + param_escape(is_pvt) + "&is_rtl=" + param_escape(is_rtl);
-
                xmlhttp.open("POST", "backend.php", true);
                xmlhttp.onreadystatechange=feedlist_callback;
                xmlhttp.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded');
-               xmlhttp.send(query); 
-       
+               xmlhttp.send(query);
+
+               closeInfoBox();
+
+               return false;
+
        } catch (e) {
                exception_error("feedEditSave", e);
        } 
@@ -783,11 +639,9 @@ function feedCatEditSave() {
 
        notify("Saving category...");
 
-       var cat_title = document.getElementById("iedit_title").value;
+       var query = Form.serialize("feed_cat_edit_form");
 
-       xmlhttp.open("GET", "backend.php?op=pref-feeds&subop=saveCat&id=" +
-               param_escape(active_feed_cat) + "&title=" + param_escape(cat_title), 
-               true);
+       xmlhttp.open("GET", "backend.php?" + query, true);
        xmlhttp.onreadystatechange=feedlist_callback;
        xmlhttp.send(null);
 
@@ -798,11 +652,13 @@ function feedCatEditSave() {
 
 function labelTest() {
 
-       var sqlexp = document.getElementById("iedit_expr").value;
-       var descr = document.getElementById("iedit_descr").value;
+       var form = document.forms['label_edit_form'];
+
+       var sql_exp = form.sql_exp.value;
+       var description = form.description.value;
 
        xmlhttp.open("GET", "backend.php?op=pref-labels&subop=test&expr=" +
-               param_escape(sqlexp) + "&descr=" + param_escape(descr), true);
+               param_escape(sql_exp) + "&descr=" + param_escape(description), true);
 
        xmlhttp.onreadystatechange=infobox_callback;
        xmlhttp.send(null);
@@ -830,6 +686,8 @@ function labelEditCancel() {
 
 //     notify("Operation cancelled.");
 
+       closeInfoBox();
+
        xmlhttp.open("GET", "backend.php?op=pref-labels", true);
        xmlhttp.onreadystatechange=labellist_callback;
        xmlhttp.send(null);
@@ -843,14 +701,8 @@ function userEditCancel() {
                return
        }
 
-       active_user = false;
-
-//     notify("Operation cancelled.");
-
-       xmlhttp.open("GET", "backend.php?op=pref-users", true);
-       xmlhttp.onreadystatechange=userlist_callback;
-       xmlhttp.send(null);
-
+       selectPrefRows('user', false); // cleanup feed selection
+       closeInfoBox();
 }
 
 function filterEditCancel() {
@@ -860,14 +712,10 @@ function filterEditCancel() {
                return
        }
 
-       active_filter = false;
-
-//     notify("Operation cancelled.");
-
-       xmlhttp.open("GET", "backend.php?op=pref-filters", true);
-       xmlhttp.onreadystatechange=filterlist_callback;
-       xmlhttp.send(null);
-
+       document.getElementById("create_filter_btn").disabled = false;
+       
+       selectPrefRows('filter', false); // cleanup feed selection
+       closeInfoBox();
 }
 
 function labelEditSave() {
@@ -879,29 +727,28 @@ function labelEditSave() {
                return
        }
 
-       var sqlexp = document.getElementById("iedit_expr").value;
-       var descr = document.getElementById("iedit_descr").value;
-
-//     notify("Saving label " + sqlexp + ": " + descr);
+       var sql_exp = document.forms["label_edit_form"].sql_exp.value;
+       var description = document.forms["label_edit_form"].description.value;
 
-       if (sqlexp.length == 0) {
-               notify("SQL expression cannot be blank.");
+       if (sql_exp.length == 0) {
+               alert("SQL Expression cannot be blank.");
                return;
        }
 
-       if (descr.length == 0) {
-               notify("Caption cannot be blank.");
+       if (description.length == 0) {
+               alert("Caption field cannot be blank.");
                return;
        }
 
+       closeInfoBox();
+
        notify("Saving label...");
 
        active_label = false;
 
-       xmlhttp.open("GET", "backend.php?op=pref-labels&subop=editSave&id=" +
-               label + "&s=" + param_escape(sqlexp) + "&d=" + param_escape(descr),
-               true);
-               
+       query = Form.serialize("label_edit_form");
+
+       xmlhttp.open("GET", "backend.php?" + query, true);              
        xmlhttp.onreadystatechange=labellist_callback;
        xmlhttp.send(null);
 
@@ -909,79 +756,55 @@ function labelEditSave() {
 
 function userEditSave() {
 
-       var user = active_user;
-
        if (!xmlhttp_ready(xmlhttp)) {
                printLockingError();
                return
        }
 
-       var login = document.getElementById("iedit_ulogin").value;
-       var level = document.getElementById("iedit_ulevel");
-
-       level = level[level.selectedIndex].id;
-       
-       var email = document.getElementById("iedit_email").value;
+       var login = document.forms["user_edit_form"].login.value;
 
        if (login.length == 0) {
-               notify("Login cannot be blank.");
+               alert("Login field cannot be blank.");
                return;
        }
-
-       if (level.length == 0) {
-               notify("User level cannot be blank.");
-               return;
-       }
-
-       active_user = false;
-
+       
        notify("Saving user...");
 
-       xmlhttp.open("GET", "backend.php?op=pref-users&subop=editSave&id=" +
-               user + "&l=" + param_escape(login) + "&al=" + param_escape(level) +
-               "&e=" + param_escape(email), true);
-               
+       closeInfoBox();
+
+       var query = Form.serialize("user_edit_form");
+       
+       xmlhttp.open("GET", "backend.php?" + query, true);                      
        xmlhttp.onreadystatechange=userlist_callback;
        xmlhttp.send(null);
-
 }
 
 
 function filterEditSave() {
 
-       var filter = active_filter;
-
        if (!xmlhttp_ready(xmlhttp)) {
                printLockingError();
                return
        }
 
-       var regexp = document.getElementById("iedit_regexp").value;
-       var match = document.getElementById("iedit_match");
-
-       var v_match = match[match.selectedIndex].text;
+       var reg_exp = document.forms["filter_edit_form"].reg_exp.value;
 
-       var feed = document.getElementById("iedit_feed");
-       var feed_id = feed[feed.selectedIndex].id;
-
-       var action = document.getElementById("iedit_filter_action");
-       var action_id = action[action.selectedIndex].id;
-
-       if (regexp.length == 0) {
-               alert("Can't save filter: match expression is blank.");
+       if (reg_exp.length == 0) {
+               alert("Filter expression field cannot be blank.");
                return;
        }
 
-       active_filter = false;
+       notify("Saving filter...");
+
+       var query = Form.serialize("filter_edit_form");
 
-       xmlhttp.open("GET", "backend.php?op=pref-filters&subop=editSave&id=" +
-               filter + "&r=" + param_escape(regexp) + "&m=" + param_escape(v_match) + 
-               "&fid=" + param_escape(feed_id) + "&aid=" + param_escape(action_id), true);
+       closeInfoBox();
 
-       notify("Saving filter...");
+       document.getElementById("create_filter_btn").disabled = false;
 
+       xmlhttp.open("GET", "backend.php?" + query, true);
        xmlhttp.onreadystatechange=filterlist_callback;
-       xmlhttp.send(null); 
+       xmlhttp.send(null);
 
 }
 
@@ -1298,6 +1121,13 @@ function selectTab(id, noupdate) {
 
                notify("Loading, please wait...", true);
 
+               // close active infobox if needed
+               closeInfoBox();
+
+               // clean up all current selections, just in case
+               active_feed_cat = false;
+               active_label = false;
+
                if (id == "feedConfig") {
                        updateFeedList();
                } else if (id == "filterConfig") {
@@ -1329,9 +1159,69 @@ function selectTab(id, noupdate) {
                }
        }
 
+       if (active_tab != id) {
+               storeInitParam("prefs_active_tab", id);
+       }
+
        active_tab = id;
+}
 
-       setCookie('ttrss_pref_acttab', active_tab);
+function backend_sanity_check_callback() {
+
+       if (xmlhttp.readyState == 4) {
+
+               try {
+               
+                       if (!xmlhttp.responseXML) {
+                               fatalError(3, "[D001, Received reply is not XML]: " + xmlhttp.responseText);
+                               return;
+                       }
+       
+                       var reply = xmlhttp.responseXML.firstChild.firstChild;
+       
+                       if (!reply) {
+                               fatalError(3, "[D002, Invalid RPC reply]: " + xmlhttp.responseText);
+                               return;
+                       }
+       
+                       var error_code = reply.getAttribute("error-code");
+               
+                       if (error_code && error_code != 0) {
+                               return fatalError(error_code, reply.getAttribute("error-msg"));
+                       }
+       
+                       debug("sanity check ok");
+
+                       var params = reply.nextSibling;
+
+                       if (params) {
+                               debug('reading init-params...');
+                               var param = params.firstChild;
+
+                               while (param) {
+                                       var k = param.getAttribute("key");
+                                       var v = param.getAttribute("value");
+                                       debug(k + " => " + v);
+                                       init_params[k] = v;                                     
+                                       param = param.nextSibling;
+                               }
+                       }
+
+                       init_second_stage();
+
+               } catch (e) {
+                       exception_error("backend_sanity_check_callback", e);
+               }
+       } 
+}
+
+function init_second_stage() {
+
+       active_tab = getInitParam("prefs_active_tab");
+       if (!active_tab) active_tab = "genConfig";
+       selectTab(active_tab);
+       
+       notify("");
 
 }
 
@@ -1342,6 +1232,11 @@ function init() {
                if (arguments.callee.done) return;
                arguments.callee.done = true;           
 
+               if (getURLParam('debug')) {
+                       document.getElementById('debug_output').style.display = 'block';
+                       debug('debug mode activated');
+               }
+
                // IE kludge
                if (!xmlhttp) {
                        document.getElementById("prefContent").innerHTML = 
@@ -1350,12 +1245,10 @@ function init() {
                        return;
                }
 
-               active_tab = getCookie("ttrss_pref_acttab");
-               if (!active_tab) active_tab = "genConfig";
-               selectTab(active_tab);
-       
-               document.onkeydown = hotkey_handler;
-               notify("");
+               xmlhttp.open("GET", "backend.php?op=rpc&subop=sanityCheck", true);
+               xmlhttp.onreadystatechange=backend_sanity_check_callback;
+               xmlhttp.send(null);
+
        } catch (e) {
                exception_error("init", e);
        }
@@ -1371,7 +1264,7 @@ function categorizeSelectedFeeds() {
        var sel_rows = getSelectedFeeds();
 
        var cat_sel = document.getElementById("sfeed_set_fcat");
-       var cat_id = cat_sel[cat_sel.selectedIndex].id;
+       var cat_id = cat_sel[cat_sel.selectedIndex].value;
 
        if (sel_rows.length > 0) {
 
@@ -1482,7 +1375,7 @@ function browserToggleExpand(id) {
 
 function validateNewPassword(form) {
        if (form.OLD_PASSWORD.value == "") {
-               alert("Current password cannot be blank");
+               alert("Old password cannot be blank");
                return false;
        }
        if (form.NEW_PASSWORD.value == "") {