controls: fix hotkeys when focusing elements
authorMike Frysinger <vapier@gentoo.org>
Sat, 28 Sep 2013 04:36:43 +0000 (00:36 -0400)
committerMike Frysinger <vapier@gentoo.org>
Sat, 28 Sep 2013 04:36:43 +0000 (00:36 -0400)
If you're trying to type into a text field, then we don't want to steal
the keypresses to switch tabs.

main.js

diff --git a/main.js b/main.js
index 266bb1e60f6b242ff3108ae858d3d9322281f9b2..16875983968fd05b34c142910747a369b2bb5517 100644 (file)
--- a/main.js
+++ b/main.js
@@ -61,17 +61,23 @@ window.onload = function() {
 };
 
 window.onkeypress = function(e) {
 };
 
 window.onkeypress = function(e) {
+       if (e.target != document.body) {
+               /* Only allow the shortcuts when the focus is on the body.
+                  Otherwise you can't type these numbers into text fields. */
+               return;
+       }
+
        switch (e.keyCode) {
        case 49: // 1
                show_page('controls');
                break;
        switch (e.keyCode) {
        case 49: // 1
                show_page('controls');
                break;
-       case 50: // 1
+       case 50: // 2
                show_page('metadata');
                break;
                show_page('metadata');
                break;
-       case 51: // 1
+       case 51: // 3
                show_page('playlist');
                break;
                show_page('playlist');
                break;
-       case 52: // 1
+       case 52: // 4
                show_page('options');
                break;
        }
                show_page('options');
                break;
        }